Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STORM-2985: Explicitly add jackson-annotations dependency in pom dependency management #2584

Merged
merged 1 commit into from
May 1, 2018

Conversation

arunmahadevan
Copy link
Contributor

This is taken care of in master via jackson-bom dependency.

@arunmahadevan arunmahadevan changed the title BUG-97743: Explicitly add jackson-annotations dependency in pom dependency management STORM-2985: Explicitly add jackson-annotations dependency in pom dependency management Mar 2, 2018
@srdo
Copy link
Contributor

srdo commented Mar 3, 2018

+1, though I'm wondering if it would make sense to add the jackson-bom dependency to 1.x instead?

@hmcl
Copy link
Contributor

hmcl commented Mar 16, 2018

+1

Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

For me, even a short-term solution is acceptable for 1.x-branch.

@asfgit asfgit merged commit cb93313 into apache:1.x-branch May 1, 2018
@srdo
Copy link
Contributor

srdo commented May 1, 2018

@arunmahadevan Thanks, sorry this took so long. Merged to 1.x, 1.1.x and 1.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants