Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STORM-2578: Apply new code style to storm-elasticsearch #2803

Merged
merged 1 commit into from Aug 20, 2018

Conversation

@milantracy
Copy link
Contributor

milantracy commented Aug 15, 2018

No description provided.

@milantracy

This comment has been minimized.

Copy link
Contributor Author

milantracy commented Aug 15, 2018

@HeartSaVioR could you review the changes? Thanks.

String index = tupleMapper.getIndex(tuple);
String type = tupleMapper.getType(tuple);
String id = tupleMapper.getId(tuple);
Map<String, String> params = tupleMapper.getParams(tuple, new HashMap<>());

This comment has been minimized.

Copy link
@danny0405

danny0405 Aug 16, 2018

should indent with Tab

This comment has been minimized.

Copy link
@milantracy

milantracy Aug 16, 2018

Author Contributor

hi Danny, we might be not allowed to indent with tab because of FileTabCharacter in checkstyle. Please correct me if I misunderstood here.

This comment has been minimized.

Copy link
@HeartSaVioR

HeartSaVioR Aug 17, 2018

Contributor

It was broken indentation (mixed tab and space) and the change fixes the indentation.

Copy link

danny0405 left a comment

Looks good broadly, then what about the checkstyle config now, did it not work for the module now?

@HeartSaVioR

This comment has been minimized.

Copy link
Contributor

HeartSaVioR commented Aug 16, 2018

@milantracy Thanks for the contribution! Could you please reduce the number of max violation count in pom.xml in storm-elasticsearch so that we can see how many spots your patch address, and also we never break it again?

@milantracy

This comment has been minimized.

Copy link
Contributor Author

milantracy commented Aug 16, 2018

Hi @HeartSaVioR , reduced the value to 0.

Copy link
Contributor

HeartSaVioR left a comment

Mostly looks great. Couple of nits. Thanks for the contribution!

*/
public interface EsLookupResultOutput extends Serializable {

/**
* Covert Elasticsearch response to a collection of {@link Values}.

This comment has been minimized.

Copy link
@HeartSaVioR

HeartSaVioR Aug 17, 2018

Contributor

nit: Covert -> Convert

String index = tupleMapper.getIndex(tuple);
String type = tupleMapper.getType(tuple);
String id = tupleMapper.getId(tuple);
Map<String, String> params = tupleMapper.getParams(tuple, new HashMap<>());

This comment has been minimized.

Copy link
@HeartSaVioR

HeartSaVioR Aug 17, 2018

Contributor

It was broken indentation (mixed tab and space) and the change fixes the indentation.

*
* @param index index name
* @param type document type to be stored
* @param id unique document id in Elastisearch

This comment has been minimized.

Copy link
@HeartSaVioR

HeartSaVioR Aug 17, 2018

Contributor

nit: Elastisearch -> Elasticsearch

@milantracy

This comment has been minimized.

Copy link
Contributor Author

milantracy commented Aug 18, 2018

thanks @HeartSaVioR, change the fix accordingly.

Copy link
Contributor

HeartSaVioR left a comment

+1

Copy link

danny0405 left a comment

+1

@asfgit asfgit merged commit 8bbee40 into apache:master Aug 20, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.