STORM-2578: Apply new code style to storm-elasticsearch #2803
Conversation
|
@HeartSaVioR could you review the changes? Thanks. |
| String index = tupleMapper.getIndex(tuple); | ||
| String type = tupleMapper.getType(tuple); | ||
| String id = tupleMapper.getId(tuple); | ||
| Map<String, String> params = tupleMapper.getParams(tuple, new HashMap<>()); |
There was a problem hiding this comment.
hi Danny, we might be not allowed to indent with tab because of FileTabCharacter in checkstyle. Please correct me if I misunderstood here.
There was a problem hiding this comment.
It was broken indentation (mixed tab and space) and the change fixes the indentation.
|
@milantracy Thanks for the contribution! Could you please reduce the number of max violation count in pom.xml in storm-elasticsearch so that we can see how many spots your patch address, and also we never break it again? |
|
Hi @HeartSaVioR , reduced the value to 0. |
| */ | ||
| public interface EsLookupResultOutput extends Serializable { | ||
|
|
||
| /** | ||
| * Covert Elasticsearch response to a collection of {@link Values}. |
There was a problem hiding this comment.
nit: Covert -> Convert
| String index = tupleMapper.getIndex(tuple); | ||
| String type = tupleMapper.getType(tuple); | ||
| String id = tupleMapper.getId(tuple); | ||
| Map<String, String> params = tupleMapper.getParams(tuple, new HashMap<>()); |
There was a problem hiding this comment.
It was broken indentation (mixed tab and space) and the change fixes the indentation.
| * | ||
| * @param index index name | ||
| * @param type document type to be stored | ||
| * @param id unique document id in Elastisearch |
There was a problem hiding this comment.
nit: Elastisearch -> Elasticsearch
|
thanks @HeartSaVioR, change the fix accordingly. |
No description provided.