STORM-3456: cassandra: fix all checkstyle warnings #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srdo
reviewed
Jul 6, 2019
| @@ -99,6 +98,7 @@ public Values toValues(OpaqueValue<ITuple> tuple) { | |||
| prev = null; | |||
| } | |||
|
|
|||
| Long currTx = (Long) values.get(index++); | |||
There was a problem hiding this comment.
I think this introduces a bug. The index is supposed to be 0 here, but the for loops above can increment it. Maybe initialize index to 1 above, and then just do get(0) here.
| @@ -87,6 +86,7 @@ public Values toValues(TransactionalValue<ITuple> tuple) { | |||
| curr = null; | |||
| } | |||
|
|
|||
| Long txId = (Long) values.get(index++); | |||
|
+1. Please fix comments in a new commit on future PRs, Github's force push diffs aren't very good yet (e.g https://github.com/apache/storm/compare/f4698976dc16f6c6303f8877ef82418ec42c8c57..e7f2c919a1a99621450a945e7ad473c0d8641a9a contains a bunch of changes outside this module), so it's hard to tell exactly what changed. It's faster to review only the new changes rather than looking at the full diff again. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.