Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE in ConsulConfigMigration #1956

Closed
obermeier opened this issue Sep 22, 2023 · 2 comments · Fixed by #1957
Closed

NPE in ConsulConfigMigration #1956

obermeier opened this issue Sep 22, 2023 · 2 comments · Fixed by #1957
Assignees
@dominikriemer
Labels
bug Something isn't working
Milestone
0.93.0

Comments

@obermeier
Copy link
Member

Apache StreamPipes version

dev (current development state)

Affected StreamPipes components

Backend

What happened?

Hi, I updated between two 0.93.0-SNAPSHOT versions and realized that I get a NPE during the execution of ConsulConfigMigration in the latest version. It is searching for a SP_PULSAR_URL entry in Consul and if it does not exists the backend terminates.
Adding a SP_PULSAR_URL entry to Consul is a quick hack.

PULSAR-URL

Is this a bug or just a strange configuration in my test env ?

How to reproduce?

No response

Expected behavior

No response

Additional technical information

No response

Are you willing to submit a PR?

Yes, I am willing to submit a PR!
@obermeier obermeier added the bug Something isn't working label Sep 22, 2023
@dominikriemer dominikriemer self-assigned this Sep 22, 2023
dominikriemer added a commit that referenced this issue Sep 22, 2023
@dominikriemer
fix(#1956): Check Pulsar URL in consul migration runner
b3751df
@dominikriemer dominikriemer linked a pull request Sep 22, 2023 that will close this issue
fix(#1956): Check Pulsar URL in consul migration runner #1957
Merged
@dominikriemer dominikriemer mentioned this issue Sep 22, 2023
Merged
@dominikriemer
Copy link
Member

Hi @obermeier, good catch 👍
Do you know if your existing 0.93.0-SNAPSHOT version was a bit older (from a time before we added the Pulsar support)?
I submitted a PR to quick-fix this, but still need to test this with an older version.

@obermeier
Copy link
Member Author

Hi @dominikriemer, thank you for this fix. I am not sure but I think it was before the Pulsar time.

dominikriemer added a commit that referenced this issue Sep 25, 2023
@dominikriemer
fix(#1956): Check Pulsar URL in consul migration runner (#1957)
1e3bfd9
@bossenti bossenti added this to the 0.93.0 milestone Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikriemer dominikriemer

Labels
bug Something isn't working
Projects
None yet
Milestone
0.93.0
Development

Successfully merging a pull request may close this issue.

fix(#1956): Check Pulsar URL in consul migration runner apache/streampipes
3 participants
@obermeier @dominikriemer @bossenti