Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#1956): Check Pulsar URL in consul migration runner #1957

Merged
merged 1 commit into from Sep 25, 2023
Merged

fix(#1956): Check Pulsar URL in consul migration runner #1957

merged 1 commit into from Sep 25, 2023
+19 −3

Conversation

dominikriemer
Copy link
Member

Purpose

See #1956

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@dominikriemer dominikriemer linked an issue Sep 22, 2023 that may be closed by this pull request
NPE in ConsulConfigMigration #1956
Closed
@github-actions github-actions bot added java Pull requests that update Java code backend Everything that is related to the StreamPipes backend labels Sep 22, 2023
RobertIndie
RobertIndie approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dominikriemer dominikriemer merged commit 1e3bfd9 into dev Sep 25, 2023
18 checks passed
@dominikriemer dominikriemer deleted the 1956-npe-in-consulconfigmigration branch September 25, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenthe tenthe tenthe approved these changes

@RobertIndie RobertIndie RobertIndie approved these changes

Assignees
No one assigned
Labels
backend Everything that is related to the StreamPipes backend java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE in ConsulConfigMigration
3 participants
@dominikriemer @tenthe @RobertIndie