[#1104] add GitHub workflow to label PRs automatically #1142

Harry262530 · 2023-01-21T04:24:35Z

Purpose

Implement a GitHub workflow that automatically assigns labels to PRs.
Fur this purpose consider to use the following GitHub action: https://github.com/actions/labeler

ToDos:

provide config file to define labeling rules
implement GitHub workflow that runs for every created PR and assigns labels to it

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

bossenti

Thanks lot for initiative @Harry262530 🙏🏼
Don't worry about the configuration file, I can take care of that part, but I'm not sure when I'll find the time, so it might take a while.

bossenti · 2023-01-21T10:11:50Z

.github/prlabeller.yml

@@ -0,0 +1,21 @@
+# Add repo label to any change in any file


This is just the example config from the GitHub action, right?
That does not suit for us, but that's not a problem.
I will take care of adapting the config accordingly.

yah,
basically i was trying to give at least one label to any issue as 'repo'

I see, but we don't use such a label
You can find an overview of all our labels here
Feel free to improve the config, if you want to

sure,
i will try my level best

bossenti · 2023-01-21T10:16:24Z

.github/workflows/prlabelling.yaml

+run-name: ${{ github.actor }} created Pull Request Labeler
+
+on:
+- pull_request_target


If I am not mistaken, this event is only produced when a PR from a forked repository is created.
This is not what we desire here. I think the more general pull_request event is better suited for us and we should filter on opening events. Read more about that here: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request

thanks for the advice
should I change it and then send another pr?

You can just leave this PR open and push new commits to your existing branch, then this PR is updated automatically

sure,
i'll do that

bossenti · 2023-01-21T10:17:29Z

config_merge.yml

@@ -0,0 +1,18 @@
+name: 'PRLabeler'


What's the purpose of this file?
From my understanding, we only need the other two files.

actually for the past 1 day i studied about pull request and labels so I saw this file on one repo, so I included it

Can you provide me with a link to an example?

bossenti · 2023-01-21T10:18:47Z

.github/workflows/prlabelling.yaml

+on:
+- pull_request_target
+
+jobs:


It would be great if you could filter for PRs created by @dependabot
To do so you can follow this example here

should i assign permissions ,contents and pull request or just leave it for default

I think this looks fine for now

bossenti · 2023-01-25T21:56:10Z

.github/pr-labeler-config.yml

@@ -0,0 +1,46 @@
+backend:
+# TODO


@tenthe @dominikriemer what do you think we should provide here?

Not sure if it's possible but we could filter for all modules starting with streampipes-* except streampipes-extensions and non-java modules

Had the same idea, I'll have a look if the config's syntax allows for that

bossenti · 2023-01-25T21:57:23Z

@tenthe @dominikriemer I came with an initial version of the label config
Although, I'm not really user whether all these file path filters will work, I would just give it a try
What do you think?

dominikriemer

Looks good to me!

dominikriemer · 2023-01-26T08:00:20Z

.github/pr-labeler-config.yml

@@ -0,0 +1,46 @@
+backend:
+# TODO


Not sure if it's possible but we could filter for all modules starting with streampipes-* except streampipes-extensions and non-java modules

dominikriemer · 2023-01-26T08:01:01Z

.github/pr-labeler-config.yml

+
+'pipeline elements':
+  - streampipes-exensions/streampipes-extensions-*/**/*
+  - streampipes-extensions/streampipes-pipeline-*/**/*


Do we have such a module in streampipes-extensions currently?

Yes we have, e.g. https://github.com/apache/streampipes/tree/dev/streampipes-extensions/streampipes-pipeline-elements-all-flink

bossenti changed the title ~~pull request for auto pr labeler~~ [#1104] add GitHub workflow to label PRs automatically Jan 21, 2023

bossenti linked an issue Jan 21, 2023 that may be closed by this pull request

Add GitHub wofklow that tags PR #1104

Closed

2 tasks

bossenti reviewed Jan 21, 2023

View reviewed changes

bossenti force-pushed the dev branch from 40959ca to 43eb5fb Compare January 25, 2023 21:54

bossenti requested review from dominikriemer and tenthe January 25, 2023 21:55

bossenti reviewed Jan 25, 2023

View reviewed changes

dominikriemer approved these changes Jan 26, 2023

View reviewed changes

tenthe approved these changes Jan 27, 2023

View reviewed changes

bossenti added enhancement New feature or request gh-actions Pull requests that update GitHub Actions code labels Feb 1, 2023

Harry262530 and others added 13 commits February 1, 2023 20:26

Create prlabelling.yaml

f862b99

pull request labeler rules

3f9c1bc

config file for merging label rules

a5d0f75

updated pull request target

2b1a41d

filter pr created by dependabot

930f668

removed repo label from every pr

4eb33a9

[apache#1104] remove unnecessary config file

c44a056

[apache#1104] provide initial version of StreamPipes label config

5ae9dba

[apache#1104] restrict pr events & provide config path

dfa13ce

[apache#1104] refactor file names

388143c

[apache#1104] add Apache license header

d592b97

[apache#1104] refine labeler config

be6fad8

[apache#1104] add sync configuration

162cf9a

bossenti force-pushed the dev branch from 92e7028 to 162cf9a Compare February 1, 2023 19:26

bossenti added the no release note Issues and PR. Add if they should not be contained in the release notes (e.g., minor refactorings). label Feb 1, 2023

bossenti added this to the 0.91.0 milestone Feb 1, 2023

bossenti merged commit 2b256ee into apache:dev Feb 1, 2023

bossenti removed this from the 0.91.0 milestone Feb 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#1104] add GitHub workflow to label PRs automatically #1142

[#1104] add GitHub workflow to label PRs automatically #1142

Harry262530 commented Jan 21, 2023 •

edited by bossenti

bossenti left a comment

bossenti Jan 21, 2023

Harry262530 Jan 21, 2023

bossenti Jan 21, 2023 •

edited

Harry262530 Jan 21, 2023

bossenti Jan 21, 2023

Harry262530 Jan 21, 2023

bossenti Jan 21, 2023

Harry262530 Jan 21, 2023

bossenti Jan 21, 2023

Harry262530 Jan 21, 2023

bossenti Jan 21, 2023 •

edited

bossenti Jan 21, 2023

Harry262530 Jan 21, 2023

bossenti Jan 21, 2023

bossenti Jan 25, 2023

dominikriemer Jan 26, 2023

bossenti Jan 26, 2023

bossenti commented Jan 25, 2023

dominikriemer left a comment

dominikriemer Jan 26, 2023

dominikriemer Jan 26, 2023

bossenti Jan 26, 2023

[#1104] add GitHub workflow to label PRs automatically #1142

[#1104] add GitHub workflow to label PRs automatically #1142

Conversation

Harry262530 commented Jan 21, 2023 • edited by bossenti

Purpose

ToDos:

Remarks

bossenti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bossenti Jan 21, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bossenti Jan 21, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bossenti commented Jan 25, 2023

dominikriemer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Harry262530 commented Jan 21, 2023 •

edited by bossenti

bossenti Jan 21, 2023 •

edited

bossenti Jan 21, 2023 •

edited