Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update archetypes template #1433

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Conversation

liuxiaocs7
Copy link
Member

@liuxiaocs7 liuxiaocs7 commented Mar 21, 2023

Purpose

update archetypes template to make the generated code conform to checkstyle,hoping makes sense.

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@github-actions github-actions bot added the java Pull requests that update Java code label Mar 21, 2023
@liuxiaocs7
Copy link
Member Author

liuxiaocs7 commented Mar 21, 2023

Hi, @dominikriemer and @bossenti, I found that the generated code is not very checkstyle compliant, so I modified the archetypes template, hopefully that works.

@bossenti bossenti added the no release note Issues and PR. Add if they should not be contained in the release notes (e.g., minor refactorings). label Mar 21, 2023
@bossenti bossenti added this to the 1.0.0 milestone Mar 21, 2023
@bossenti
Copy link
Contributor

Thanks a lot @liuxiaocs7 🙏🏼
i like your eye for details 🙂

@dominikriemer
Copy link
Member

Thank you. My IDE always gets crazy when working with archetype files ;-)

@dominikriemer dominikriemer merged commit a42fe29 into apache:dev Mar 21, 2023
@bossenti bossenti modified the milestones: 1.0.0, 0.92.0 May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code no release note Issues and PR. Add if they should not be contained in the release notes (e.g., minor refactorings).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants