Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration hint for Kafka users. #1945

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Add configuration hint for Kafka users. #1945

merged 2 commits into from
Oct 2, 2023

Conversation

obermeier
Copy link
Member

@obermeier obermeier commented Sep 18, 2023

Purpose

I think we have very nice examples of how to use the StreamPipes Python client. I have a suggestion on how to improve the user experience further related to Kafka configuration for less experienced users .

In the given example, localhost as hostname is used as the hostname. I think this could lead to the assumption that arbitrary hostnames or IPs are possible by default.
For this reason, I suggest adding a small hint for non-Kafka-experienced users that the external address should be advertised by Kafka by adjusting KAFKA_ADVERTISED_LISTENERS.

Example for the docker-compose env: KAFKA_ADVERTISED_LISTENERS: PLAINTEXT://:9092,OUTSIDE://{EXTERNAL_ADDRESS}:9094

"What do you think of this idea?
Do you prefer another place to explain situations like this?"

PR introduces (a) breaking change(s):

PR introduces (a) deprecation(s):

@tenthe
Copy link
Contributor

tenthe commented Sep 19, 2023

Hi @obermeier,
thanks for the PR. I really like the idea.
I also think it makes sense to write a small comment in the docker-compose file. So that a user knows directly where and how to change the kafka configurations.
Cheers,
Philipp

@bossenti
Copy link
Contributor

this is a great addition @obermeier 🙏🏼

@github-actions github-actions bot added installer Affects the StreamPipes installer documentation Everything related to documentation helm Affects the StreamPipes helm chart labels Sep 22, 2023
@bossenti bossenti merged commit 714f462 into dev Oct 2, 2023
18 checks passed
@bossenti bossenti deleted the obermeier-patch-1 branch October 2, 2023 07:54
@bossenti bossenti added this to the 0.93.0 milestone Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Everything related to documentation helm Affects the StreamPipes helm chart installer Affects the StreamPipes installer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants