Add configuration hint for Kafka users. #1945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I think we have very nice examples of how to use the StreamPipes Python client. I have a suggestion on how to improve the user experience further related to Kafka configuration for less experienced users .
In the given example, localhost as hostname is used as the hostname. I think this could lead to the assumption that arbitrary hostnames or IPs are possible by default.
For this reason, I suggest adding a small hint for non-Kafka-experienced users that the external address should be advertised by Kafka by adjusting KAFKA_ADVERTISED_LISTENERS.
Example for the docker-compose env:
KAFKA_ADVERTISED_LISTENERS: PLAINTEXT://:9092,OUTSIDE://{EXTERNAL_ADDRESS}:9094
"What do you think of this idea?
Do you prefer another place to explain situations like this?"
PR introduces (a) breaking change(s):
PR introduces (a) deprecation(s):