SUBMARINE-598. Support get environment list from database

[kobe860219]

What is this PR for?

Improve environment swagger api.
When cache is null. Will get environment data from database.

What type of PR is it?

[Improvement]

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-598

How should this be tested?

https://travis-ci.org/github/kobe860219/submarine/builds/716904008?utm_source=github_status&utm_medium=notification

Screenshots (if appropriate)

Questions:

• Does the licenses files need update? No
• Is there breaking changes for older versions? No
• Does this needs documentation? No

[kobe860219]

@liuxunorg @pingsutw @JohnTing Please help me review this pr. Thanks :)

[jiwq]

Thanks @kobe860219 for the contribution.

[xunliu]

If direct return envs, Will this cause envs variable to never update?

[kobe860219]

@jiwq @liuxunorg @pingsutw @JohnTing I updated this pr and screenshots. I add a path /list that support get environments data from database by /v1/environment/list . It is able to support environment page of workbench show environments list from database.

[pingsutw]

There is a listEnvironment in EnvironmentRestApi.java, why create a new function listAllEnvironments?

submarine/submarine-server/server-core/src/main/java/org/apache/submarine/server/rest/EnvironmentRestApi.java

Lines 151 to 159 in cc9dde5

	public Response listEnvironment(@QueryParam("status") String status) {
	try {
	List<Environment> environmentList =
	environmentManager.listEnvironments(status);
	return new JsonResponse.Builder<List<Environment>>(Response.Status.OK)
	.success(true).result(environmentList).build();
	} catch (SubmarineRuntimeException e) {
	return parseEnvironmentServiceException(e);
	}

[kobe860219]

listEnvironment just get those environments in cache. listAllEnvironments will get environments from database.

[jiwq]

I think we can merge it rather than create new.

[kobe860219]

I will merge it.

[manirajv06]

@kobe860219 Thanks for working on this. Even from API end point perspective, I don't see a need for "list". Just typing "/v1/environment" should return the list of environments. Change is required only in model layer.

[kobe860219]

@jiwq @pingsutw @manirajv06 I have updated this pr. Please take a look, Thanks :))

[jiwq]

@kobe860219 Could you fix the failed tests: EnvironmentRestApiTest.listEnvironment:129 expected:<1> but was:<2>? https://travis-ci.org/github/apache/submarine/jobs/718209689

[kobe860219]

@jiwq I have fixed the failed tests :)

[jiwq]

+1 Will commit if no more comments.

[xunliu]

LGTM