This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-596. [WEB] Implement environment list through UI #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pingsutw @liuxunorg Please help me review this pr. Thanks a lot :)) |
pingsutw
reviewed
Aug 14, 2020
submarine-workbench/workbench-web-ng/src/app/services/environment.service.ts
Outdated
Show resolved
Hide resolved
|
@kobe860219 I found that the environment ID is empty in the screenshot. |
|
@pingsutw I have removed the column of environment ID. |
jiwq
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
+1 Thanks @kobe860219 for the contributions. Thanks @pingsutw help to review. Commit it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
What type of PR is it?
[Feature]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-596
How should this be tested?
https://travis-ci.org/github/kobe860219/submarine/builds/717500078
Screenshots (if appropriate)
Questions: