This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-610. [WEB] Refactor experiment.component #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Customized form is now in the separate file called experiment-customized-form.tx. Parent(experiment.ts) communicates with it by rxjs Subject and Observable.
wang0630
force-pushed
the
SUBMARINE-610
branch
2 times, most recently
from
d3ea33d
to
d94d5cf
Compare
wang0630
force-pushed
the
SUBMARINE-610
branch
from
d94d5cf
to
71b850d
Compare
pingsutw
reviewed
Aug 31, 2020
There was a problem hiding this comment.
Thanks @wang0630 for the contribution.
Some comments in the below.
@kobe860219 @liuxunorg could you also take a look at it, thanks.
submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/experimentIT.java
Outdated
Show resolved
Hide resolved
submarine-workbench/workbench-web-ng/src/app/interfaces/modal-props.ts
Outdated
Show resolved
Hide resolved
...ages/workbench/experiment/experiment-customized-form/experiment-customized-form.component.ts
Show resolved
Hide resolved
|
Will commit if no more comment. |
pingsutw
approved these changes
Sep 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Separate form in
experiment.componentto another file, and using RXJSSubjectandObservableto communicate between components.What type of PR is it?
[Refactoring]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-610?filter=-1
How should this be tested?
https://github.com/wang0630/submarine/runs/1046727907
Screenshots (if appropriate)
Questions: