This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-1126. Let Jupyter Notebook save user setting after pod restarted. #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KUAN-HSUN-LI
approved these changes
Dec 20, 2021
There was a problem hiding this comment.
LGTM. @jeff-901 Can you also take a look? Maybe we can also save the experimentId into the PVC?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Jupyter Notebook have created a workspace volume
/home/jovyan/workspace, but the user settings are saved in/home/jovyan/.jupyter/lab/user-settings/@jupyterlab/.So that after pod restart, submarine will lost user settings. I think we should add a new volume to save user settings in
/home/jovyan/.jupyter/.What type of PR is it?
Improvement
Todos
notebook-pvc-user-*when creating notebook pod CRDWhat is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1126
How should this be tested?
There are no new test cases right now.
Screenshots (if appropriate)
Questions: