Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML lang="en" #18

Closed
wants to merge 1 commit into from
Closed

Add HTML lang="en" #18

wants to merge 1 commit into from

Conversation

skotfred
Copy link

Primarily an accessibility concern for screen reader software.

Primarily an accessibility concern for screen reader software.
@julianfoad
Copy link
Member

Hello. Thanks for offering a contribution to the Subversion project. Unfortunately, we looked at your patch and it seems that the changes themselves are mostly irrelevant, and those that add the "lang" attribute where it's not allowed by the DTD are actually wrong.

We encourage contributors to start at these pages:

https://subversion.apache.org/contributing.html
https://subversion.apache.org/reporting-issues.html

If you write to the mailing list, as described there, then we can help you come up with a correct fix for any problems you are seeing.

Thanks,

  • Julian

@skotfred skotfred closed this Jan 30, 2019
@rhuijben
Copy link
Contributor

rhuijben commented Feb 18, 2019

The HTML 5 standard (As hosted on w3.org) explicitly allows the lang attribute on each element, including ''. See https://www.w3.org/TR/html52/dom.html#the-lang-and-xmllang-attributes

I'm not sure which DTD is refered to as 'the standard', but it is most likely targeting an outdated HTML version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants