Skip to content

Commit

Permalink
fix(caching): support metastore cache for non-required caches (#19369)
Browse files Browse the repository at this point in the history
* fix(caching): support metastore cache for non-required caches

* lint
  • Loading branch information
villebro committed Mar 25, 2022
1 parent 6141a9a commit 02308a6
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions superset/utils/cache_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def _init_cache(
) -> None:
cache_config = app.config[cache_config_key]
cache_type = cache_config.get("CACHE_TYPE")
if required and cache_type in (None, "SupersetMetastoreCache"):
if (required and cache_type is None) or cache_type == "SupersetMetastoreCache":
if cache_type is None and not app.debug:
logger.warning(
"Falling back to the built-in cache, that stores data in the "
Expand All @@ -49,12 +49,13 @@ def _init_cache(
"another dedicated caching backend for production deployments",
cache_config_key,
)
cache_type = CACHE_IMPORT_PATH
cache_key_prefix = cache_config.get("CACHE_KEY_PREFIX", cache_config_key)
cache_config.update(
{"CACHE_TYPE": CACHE_IMPORT_PATH, "CACHE_KEY_PREFIX": cache_key_prefix}
{"CACHE_TYPE": cache_type, "CACHE_KEY_PREFIX": cache_key_prefix}
)

if "CACHE_DEFAULT_TIMEOUT" not in cache_config:
if cache_type is not None and "CACHE_DEFAULT_TIMEOUT" not in cache_config:
default_timeout = app.config.get("CACHE_DEFAULT_TIMEOUT")
cache_config["CACHE_DEFAULT_TIMEOUT"] = default_timeout

Expand Down

0 comments on commit 02308a6

Please sign in to comment.