Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(caching): support metastore cache for non-required caches #19369

Merged
merged 2 commits into from
Mar 25, 2022

Conversation

villebro
Copy link
Member

SUMMARY

In the original PR #19232, it was only possible to use the new Metastore Cache for required caches. This makes it possible to also use it for other caching purposes.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #19369 (90e2d71) into master (6141a9a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #19369   +/-   ##
=======================================
  Coverage   66.67%   66.67%           
=======================================
  Files        1676     1676           
  Lines       64714    64715    +1     
  Branches     6506     6506           
=======================================
+ Hits        43150    43151    +1     
  Misses      19878    19878           
  Partials     1686     1686           
Flag Coverage Δ
hive 52.75% <66.66%> (-0.01%) ⬇️
mysql 81.68% <100.00%> (+<0.01%) ⬆️
postgres 81.72% <100.00%> (+<0.01%) ⬆️
presto 52.60% <66.66%> (-0.01%) ⬇️
python 82.14% <100.00%> (+<0.01%) ⬆️
sqlite 81.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/cache_manager.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6141a9a...90e2d71. Read the comment docs.

@villebro villebro merged commit 02308a6 into apache:master Mar 25, 2022
@villebro villebro deleted the villebro/default-cache-2 branch March 25, 2022 14:19
villebro added a commit that referenced this pull request Apr 3, 2022
* fix(caching): support metastore cache for non-required caches

* lint

(cherry picked from commit 02308a6)
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
…#19369)

* fix(caching): support metastore cache for non-required caches

* lint
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants