fix crash

apache · Jun 21, 2022 · 4efc210 · 4efc210
1 parent ad82ce6
commit 4efc210
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/superset-frontend/packages/superset-ui-core/src/translation/Translator.ts b/superset-frontend/packages/superset-ui-core/src/translation/Translator.ts
@@ -56,7 +56,7 @@ export default class Translator {
    */
   addTranslation(key: string, texts: ReadonlyArray<string>) {
     const translations = this.i18n.options.locale_data.superset;
-    if (process?.env?.NODE_ENV !== 'test' && key in translations) {
+    if (process.env.WEBPACK_MODE !== 'test' && key in translations) {
       logging.warn(`Duplicate translation key "${key}", will override.`);
     }
     translations[key] = texts;

diff --git a/superset-frontend/packages/superset-ui-core/test/translation/Translator.test.ts b/superset-frontend/packages/superset-ui-core/test/translation/Translator.test.ts
@@ -41,12 +41,12 @@ describe('Translator', () => {
     spy.mockImplementation((info: any) => {
       throw new Error(info);
     });
-    process.env.NODE_ENV = 'production';
+    process.env.WEBPACK_MODE = 'production';
   });
 
   afterAll(() => {
     spy.mockRestore();
-    process.env.NODE_ENV = 'test';
+    process.env.WEBPACK_MODE = 'test';
   });
 
   describe('new Translator(config)', () => {

diff --git a/superset-frontend/spec/helpers/shim.ts b/superset-frontend/spec/helpers/shim.ts
@@ -81,3 +81,5 @@ setupSupersetClient();
 jest.mock('src/hooks/useTabId', () => ({
   useTabId: () => 1,
 }));
+
+process.env.WEBPACK_MODE = 'test';