Skip to content

Commit

Permalink
feat(embedded-SDK): enable CSV download (#20416)
Browse files Browse the repository at this point in the history
* feat(embedded-sdk): enable CSV download

* lint
  • Loading branch information
lilykuang committed Aug 3, 2022
1 parent aa53c10 commit 655646d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion superset-embedded-sdk/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,10 @@ export async function embedDashboard({
iframe.sandbox.add("allow-scripts"); // obviously the iframe needs scripts
iframe.sandbox.add("allow-presentation"); // for fullscreen charts
iframe.sandbox.add("allow-downloads"); // for downloading charts as image
iframe.sandbox.add("allow-forms"); // for forms to submit
iframe.sandbox.add("allow-popups"); // for exporting charts as csv
// add these ones if it turns out we need them:
// iframe.sandbox.add("allow-top-navigation");
// iframe.sandbox.add("allow-forms");

// add the event listener before setting src, to be 100% sure that we capture the load event
iframe.addEventListener('load', () => {
Expand Down

0 comments on commit 655646d

Please sign in to comment.