Skip to content

Commit

Permalink
chore: Use redis 7 on tests and pin on local dev and non-dev (#22742)
Browse files Browse the repository at this point in the history
  • Loading branch information
dpgaspar committed Jan 16, 2023
1 parent 3ed288d commit 6d37e66
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/superset-applitool-cypress.yml
Expand Up @@ -32,7 +32,7 @@ jobs:
ports:
- 15432:5432
redis:
image: redis:5-alpine
image: redis:7-alpine
ports:
- 16379:6379
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/superset-cli.yml
Expand Up @@ -30,7 +30,7 @@ jobs:
# GitHub action runner's default installations
- 15432:5432
redis:
image: redis:5-alpine
image: redis:7-alpine
ports:
- 16379:6379
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/superset-e2e.yml
Expand Up @@ -38,7 +38,7 @@ jobs:
ports:
- 15432:5432
redis:
image: redis:5-alpine
image: redis:7-alpine
ports:
- 16379:6379
steps:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/superset-python-integrationtest.yml
Expand Up @@ -29,7 +29,7 @@ jobs:
ports:
- 13306:3306
redis:
image: redis:5-alpine
image: redis:7-alpine
options: --entrypoint redis-server
ports:
- 16379:6379
Expand Down Expand Up @@ -97,7 +97,7 @@ jobs:
# GitHub action runner's default installations
- 15432:5432
redis:
image: redis:5-alpine
image: redis:7-alpine
ports:
- 16379:6379
steps:
Expand Down Expand Up @@ -156,7 +156,7 @@ jobs:
sqlite:///${{ github.workspace }}/.temp/unittest.db
services:
redis:
image: redis:5-alpine
image: redis:7-alpine
ports:
- 16379:6379
steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/superset-python-presto-hive.yml
Expand Up @@ -41,7 +41,7 @@ jobs:
# GitHub action runner's default installations
- 15433:8080
redis:
image: redis:5-alpine
image: redis:7-alpine
ports:
- 16379:6379
steps:
Expand Down Expand Up @@ -110,7 +110,7 @@ jobs:
# GitHub action runner's default installations
- 15432:5432
redis:
image: redis:5-alpine
image: redis:7-alpine
ports:
- 16379:6379
steps:
Expand Down
4 changes: 2 additions & 2 deletions docker-compose-non-dev.yml
Expand Up @@ -26,15 +26,15 @@ x-superset-volumes: &superset-volumes
version: "3.7"
services:
redis:
image: redis:latest
image: redis:7
container_name: superset_cache
restart: unless-stopped
volumes:
- redis:/data

db:
env_file: docker/.env-non-dev
image: postgres:10
image: postgres:14
container_name: superset_db
restart: unless-stopped
volumes:
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Expand Up @@ -30,7 +30,7 @@ x-superset-volumes: &superset-volumes
version: "3.7"
services:
redis:
image: redis:latest
image: redis:7
container_name: superset_cache
restart: unless-stopped
ports:
Expand Down

1 comment on commit 6d37e66

@maxboaventura
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry to bump here, but pin Postgres to version 14 is breaking upgrade on previous install when a previous Postgres 10 is found. Check below:

superset_db | PostgreSQL Database directory appears to contain a database; Skipping initialization superset_db | superset_db | 2023-01-29 21:44:29.599 UTC [1] FATAL: database files are incompatible with server superset_db | 2023-01-29 21:44:29.599 UTC [1] DETAIL: The data directory was initialized by PostgreSQL version 10, which is not compatible with this version 11.16 (Debian 11.16-1.pgdg90+1). superset_db exited with code 1

I already see an issue saying "Can't start... docker-compose"

Please sign in to comment.