chore: Use redis 7 on tests and pin on local dev and non-dev #22742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22742 +/- ##
===========================================
- Coverage 67.11% 56.01% -11.10%
===========================================
Files 1869 1869
Lines 71612 71612
Branches 7822 7822
===========================================
- Hits 48059 40113 -7946
- Misses 21526 29472 +7946
Partials 2027 2027
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dpgaspar
changed the title
villebro
approved these changes
Jan 16, 2023
Comment on lines
-37
to
38
| image: postgres:10 | ||
| image: postgres:14 | ||
| container_name: superset_db |
There was a problem hiding this comment.
Should we mention this bump in the title/description, too?
dpgaspar
changed the title
dpgaspar
deleted the
danielgaspar/sc-65405/upgrade-redis-on-local-dev-environment-for
branch
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Pins Redis to major version 7 on local dev and non-dev environments
Updates current tests to run against Redis version 7, current redis 5 has reached EOL: https://endoflife.date/redis
https://docs.redis.com/latest/rs/installing-upgrading/product-lifecycle/
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION