fix(explore): fix y-axis lower bound 0 value (#15091)

apache · Jun 13, 2021 · 856a2bd · 856a2bd
1 parent 8e6a5a6
commit 856a2bd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/superset-frontend/spec/javascripts/explore/components/BoundsControl_spec.jsx b/superset-frontend/spec/javascripts/explore/components/BoundsControl_spec.jsx
@@ -51,3 +51,12 @@ test('calls onChange with correct values', async () => {
     expect(defaultProps.onChange).toHaveBeenLastCalledWith([1, 2]),
   );
 });
+
+test('receives 0 value', async () => {
+  render(<BoundsControl {...defaultProps} />);
+  const minInput = screen.getAllByRole('spinbutton')[0];
+  userEvent.type(minInput, '0');
+  await waitFor(() =>
+    expect(defaultProps.onChange).toHaveBeenLastCalledWith([0, null]),
+  );
+});
diff --git a/superset-frontend/src/explore/components/controls/BoundsControl.jsx b/superset-frontend/src/explore/components/controls/BoundsControl.jsx
@@ -97,8 +97,8 @@ export default class BoundsControl extends React.Component {
 
   onChange() {
     const mm = this.state.minMax;
-    const min = parseFloat(mm[0]) || null;
-    const max = parseFloat(mm[1]) || null;
+    const min = Number.isNaN(parseFloat(mm[0])) ? null : parseFloat(mm[0]);
+    const max = Number.isNaN(parseFloat(mm[1])) ? null : parseFloat(mm[1]);
     this.props.onChange([min, max]);
   }