-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): fix y-axis lower bound 0 value #15091
Conversation
/testenv up |
@junlincc Ephemeral environment spinning up at http://54.189.190.44:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #15091 +/- ##
==========================================
- Coverage 77.62% 77.54% -0.08%
==========================================
Files 967 969 +2
Lines 49702 49870 +168
Branches 6338 6383 +45
==========================================
+ Hits 38579 38672 +93
- Misses 10920 10996 +76
+ Partials 203 202 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This pr fixes the viz that cannot be updated when the y-axis lower bound is changed to 0.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
2021-06-10.11.08.09.mov
After
2021-06-10.11.09.22.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION