Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): fix y-axis lower bound 0 value #15091

Merged
merged 2 commits into from
Jun 13, 2021

Conversation

stephenLYZ
Copy link
Member

@stephenLYZ stephenLYZ commented Jun 10, 2021

SUMMARY

This pr fixes the viz that cannot be updated when the y-axis lower bound is changed to 0.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

2021-06-10.11.08.09.mov

After

2021-06-10.11.09.22.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: [Explore] Cannot set y-axis lower bound to 0 on Line Chart #14998
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc junlincc added explore:control Related to the controls panel of Explore bash! labels Jun 10, 2021
@junlincc
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://54.189.190.44:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for lint, LGTM

closes: #14998

image

@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #15091 (b76426a) into master (c0eff8f) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15091      +/-   ##
==========================================
- Coverage   77.62%   77.54%   -0.08%     
==========================================
  Files         967      969       +2     
  Lines       49702    49870     +168     
  Branches     6338     6383      +45     
==========================================
+ Hits        38579    38672      +93     
- Misses      10920    10996      +76     
+ Partials      203      202       -1     
Flag Coverage Δ
javascript 72.37% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/explore/components/controls/BoundsControl.jsx 97.43% <100.00%> (ø)
...nd/src/dashboard/components/nativeFilters/state.ts 75.00% <0.00%> (-25.00%) ⬇️
.../controls/MetricControl/FilterDefinitionOption.jsx 90.00% <0.00%> (-10.00%) ⬇️
superset-frontend/src/explore/constants.ts 97.36% <0.00%> (-2.64%) ⬇️
...perset-frontend/src/views/CRUD/welcome/Welcome.tsx 81.30% <0.00%> (-2.57%) ⬇️
...tend/src/views/CRUD/data/database/DatabaseList.tsx 78.07% <0.00%> (-2.31%) ⬇️
.../src/views/CRUD/data/savedquery/SavedQueryList.tsx 72.91% <0.00%> (-1.72%) ⬇️
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 74.62% <0.00%> (-1.38%) ⬇️
superset-frontend/src/views/CRUD/utils.tsx 63.86% <0.00%> (-1.26%) ⬇️
...-frontend/src/views/CRUD/welcome/ActivityTable.tsx 78.43% <0.00%> (-1.17%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0eff8f...b76426a. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@zhaoyongjie zhaoyongjie merged commit 856a2bd into apache:master Jun 13, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:control Related to the controls panel of Explore size/S 🚢 1.3.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants