Skip to content

Commit

Permalink
fix(sqllab): fix control x to stop query (#21899)
Browse files Browse the repository at this point in the history
  • Loading branch information
pkdotson committed Oct 24, 2022
1 parent c19708b commit 88e98d5
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions superset-frontend/src/SqlLab/components/SqlEditor/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ const SqlEditor = ({
if (latestQuery && ['running', 'pending'].indexOf(latestQuery.state) >= 0) {
dispatch(postStopQuery(latestQuery));
}
return false;
};

const runQuery = () => {
Expand All @@ -244,7 +245,6 @@ const SqlEditor = ({
const getHotkeyConfig = () => {
// Get the user's OS
const userOS = detectOS();

const base = [
{
name: 'runQuery1',
Expand Down Expand Up @@ -326,18 +326,21 @@ const SqlEditor = ({
window.addEventListener('resize', handleWindowResizeWithThrottle);
window.addEventListener('beforeunload', onBeforeUnload);

// setup hotkeys
const hotkeys = getHotkeyConfig();
hotkeys.forEach(keyConfig => {
Mousetrap.bind([keyConfig.key], keyConfig.func);
});

return () => {
window.removeEventListener('resize', handleWindowResizeWithThrottle);
window.removeEventListener('beforeunload', onBeforeUnload);
};
}, []);

useEffect(() => {
// setup hotkeys
Mousetrap.reset();
const hotkeys = getHotkeyConfig();
hotkeys.forEach(keyConfig => {
Mousetrap.bind([keyConfig.key], keyConfig.func);
});
}, [latestQuery]);

const onResizeStart = () => {
// Set the heights on the ace editor and the ace content area after drag starts
// to smooth out the visual transition to the new heights when drag ends
Expand Down

0 comments on commit 88e98d5

Please sign in to comment.