fix(sqllab): fix control x to stop query #21899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/testenv up |
Codecov Report
@@ Coverage Diff @@
## master #21899 +/- ##
==========================================
+ Coverage 66.85% 66.89% +0.04%
==========================================
Files 1805 1806 +1
Lines 69058 69119 +61
Branches 7368 7393 +25
==========================================
+ Hits 46167 46239 +72
+ Misses 20995 20971 -24
- Partials 1896 1909 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@pkdotson Ephemeral environment spinning up at http://35.92.164.144:8080. Credentials are |
eschutho
reviewed
Oct 21, 2022
| @@ -219,6 +219,7 @@ const SqlEditor = ({ | |||
| if (latestQuery && ['running', 'pending'].indexOf(latestQuery.state) >= 0) { | |||
| dispatch(postStopQuery(latestQuery)); | |||
| } | |||
| return false; | |||
There was a problem hiding this comment.
yes to prevent the event from bubbling up. This is for the stopquery fn. Mousetrap sometimes recommends this.
hughhhh
approved these changes
Oct 24, 2022
|
Ephemeral environment shutdown and build artifacts deleted. |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
After the refactor of the sqleditor component users weren't able to to stop query by control + x. This pr ensures that the component rebinds the mouestrap keys when latesquery is updated.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
after
Screen.Recording.2022-10-21.at.3.06.30.PM.mov
TESTING INSTRUCTIONS
Go to sqllab and run a query and use the control + x key to stop the query.
ADDITIONAL INFORMATION