Skip to content

Commit

Permalink
fix: Line Chart Annotation Info Update (#19001)
Browse files Browse the repository at this point in the history
* fix Line Chart Annotation Info Updage

* wrap annotation text with transation

* resolve comment
  • Loading branch information
codemaster08240328 committed Apr 14, 2022
1 parent 34008f7 commit ac2c66c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -385,11 +385,13 @@ export default class AnnotationLayer extends React.PureComponent {
description = 'Select the Annotation Layer you would like to use.';
} else {
label = t('Chart');
description = `Use a pre defined Superset Chart as a source for annotations and overlays.
your chart must be one of these visualization types:
[${this.getSupportedSourceTypes(annotationType)
.map(x => x.label)
.join(', ')}]`;
description = t(
`Use another existing chart as a source for annotations and overlays.
Your chart must be one of these visualization types: [%s]`,
this.getSupportedSourceTypes(annotationType)
.map(x => x.label)
.join(', '),
);
}
} else if (annotationType === ANNOTATION_TYPES.FORMULA) {
label = 'Formula';
Expand Down
4 changes: 2 additions & 2 deletions superset/translations/zh/LC_MESSAGES/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -2824,8 +2824,8 @@
"Annotation Source": ["注释来源"],
"No options": ["没有选项"],
"Superset annotation": ["Superset注释"],
"Use a pre defined Superset Chart as a source for annotations and overlays. your chart must be one of these visualization types:": [
"使用预定义的图表作为注释和覆盖的源。图表必须是以下可视化类型之一:"
"Use another existing chart as a source for annotations and overlays. Your chart must be one of these visualization types: [%s]": [
"使用预定义的图表作为注释和覆盖的源。图表必须是以下可视化类型之一: [%s]"
],
"Expects a formula with depending time parameter 'x'\n in milliseconds since epoch. mathjs is used to evaluate the formulas.\n Example: '2x+5'": [
"需要一个从Epoch(1970年1月1日00:00:00 UTC)时间点开始的时间参数“x”,并以此来计算的公式(以毫秒为单位)。我们使用“mathjs”来进行公式的计算。例如:'2x+5'"
Expand Down

0 comments on commit ac2c66c

Please sign in to comment.