fix: Line Chart Annotation Info Update #19001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemaster08240328
changed the title
Codecov Report
@@ Coverage Diff @@
## master #19001 +/- ##
==========================================
- Coverage 66.49% 66.32% -0.17%
==========================================
Files 1681 1681
Lines 64370 64370
Branches 6583 6583
==========================================
- Hits 42803 42695 -108
- Misses 19886 19994 +108
Partials 1681 1681
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
requested changes
Mar 3, 2022
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx
Outdated
Show resolved
Hide resolved
rusackas
reviewed
Mar 10, 2022
rusackas
reviewed
Mar 10, 2022
rusackas
reviewed
Mar 10, 2022
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx
Show resolved
Hide resolved
diegomedina248
approved these changes
Mar 11, 2022
rusackas
approved these changes
Mar 16, 2022
|
@codemaster08240328 please rebase so this can pass CI. |
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
* fix Line Chart Annotation Info Updage * wrap annotation text with transation * resolve comment
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In production annotation verbiage is a bit confusing for a new user.
Feedback from Opendoor was to clarify that the chart being referenced is a chart created by the user/team.
Clear instruction should be needed.