-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: Adds storybook and tests to PopoverDropdown component (#13547)
* test: Adds storybook and tests to PopoverDropdown component * Changes to use gridUnit and theme hook
- Loading branch information
1 parent
e61f5a9
commit be8f8d9
Showing
6 changed files
with
249 additions
and
75 deletions.
There are no files selected for viewing
94 changes: 94 additions & 0 deletions
94
superset-frontend/src/components/PopoverDropdown/PopoverDropdown.stories.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import React, { useState } from 'react'; | ||
| import PopoverDropdown, { PopoverDropdownProps, OptionProps } from '.'; | ||
|
|
||
| export default { | ||
| title: 'PopoverDropdown', | ||
| includeStories: ['InteractivePopoverDropdown'], | ||
| }; | ||
|
|
||
| export const OPTIONS: OptionProps[] = [ | ||
| { label: 'Option A', value: 'A' }, | ||
| { label: 'Option B', value: 'B' }, | ||
| { label: 'Option C', value: 'C' }, | ||
| ]; | ||
|
|
||
| type ElementType = 'default' | 'button'; | ||
|
|
||
| type Props = PopoverDropdownProps & { | ||
| buttonType: ElementType; | ||
| optionType: ElementType; | ||
| }; | ||
|
|
||
| export const InteractivePopoverDropdown = (props: Props) => { | ||
| const { value, buttonType, optionType, ...rest } = props; | ||
| const [currentValue, setCurrentValue] = useState(value); | ||
|
|
||
| const newElementHandler = (type: ElementType) => ({ | ||
| label, | ||
| value, | ||
| }: OptionProps) => { | ||
| if (type === 'button') { | ||
| return ( | ||
| <button type="button" key={value}> | ||
| {label} | ||
| </button> | ||
| ); | ||
| } | ||
| return <span>{label}</span>; | ||
| }; | ||
|
|
||
| return ( | ||
| <PopoverDropdown | ||
| {...rest} | ||
| value={currentValue} | ||
| renderButton={newElementHandler(buttonType)} | ||
| renderOption={newElementHandler(optionType)} | ||
| onChange={selected => setCurrentValue(selected as string)} | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| InteractivePopoverDropdown.argTypes = { | ||
| buttonType: { | ||
| defaultValue: 'default', | ||
| control: { type: 'radio', options: ['default', 'button'] }, | ||
| }, | ||
| optionType: { | ||
| defaultValue: 'default', | ||
| control: { type: 'radio', options: ['default', 'button'] }, | ||
| }, | ||
| value: { | ||
| defaultValue: OPTIONS[0].value, | ||
| table: { disable: true }, | ||
| }, | ||
| options: { | ||
| defaultValue: OPTIONS, | ||
| table: { disable: true }, | ||
| }, | ||
| }; | ||
|
|
||
| InteractivePopoverDropdown.story = { | ||
| parameters: { | ||
| knobs: { | ||
| disable: true, | ||
| }, | ||
| }, | ||
| }; |
86 changes: 86 additions & 0 deletions
86
superset-frontend/src/components/PopoverDropdown/PopoverDropdown.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import React from 'react'; | ||
| import { render, screen } from 'spec/helpers/testing-library'; | ||
| import userEvent from '@testing-library/user-event'; | ||
| import PopoverDropdown, { | ||
| PopoverDropdownProps, | ||
| OptionProps, | ||
| } from 'src/components/PopoverDropdown'; | ||
|
|
||
| const defaultProps: PopoverDropdownProps = { | ||
| id: 'popover-dropdown', | ||
| options: [ | ||
| { label: 'Option 1', value: '1' }, | ||
| { label: 'Option 2', value: '2' }, | ||
| ], | ||
| value: '1', | ||
| renderButton: (option: OptionProps) => <span>{option.label}</span>, | ||
| renderOption: (option: OptionProps) => <div>{option.label}</div>, | ||
| onChange: jest.fn(), | ||
| }; | ||
|
|
||
| test('renders with default props', () => { | ||
| render(<PopoverDropdown {...defaultProps} />); | ||
| expect(screen.getByRole('button')).toBeInTheDocument(); | ||
| expect(screen.getByRole('button')).toHaveTextContent('Option 1'); | ||
| }); | ||
|
|
||
| test('renders the menu on click', () => { | ||
| render(<PopoverDropdown {...defaultProps} />); | ||
| userEvent.click(screen.getByRole('button')); | ||
| expect(screen.getByRole('menu')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| test('renders with custom button', () => { | ||
| render( | ||
| <PopoverDropdown | ||
| {...defaultProps} | ||
| renderButton={({ label, value }: OptionProps) => ( | ||
| <button type="button" key={value}> | ||
| {`Custom ${label}`} | ||
| </button> | ||
| )} | ||
| />, | ||
| ); | ||
| expect(screen.getByText('Custom Option 1')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| test('renders with custom option', () => { | ||
| render( | ||
| <PopoverDropdown | ||
| {...defaultProps} | ||
| renderOption={({ label, value }: OptionProps) => ( | ||
| <button type="button" key={value}> | ||
| {`Custom ${label}`} | ||
| </button> | ||
| )} | ||
| />, | ||
| ); | ||
| userEvent.click(screen.getByRole('button')); | ||
| expect(screen.getByText('Custom Option 1')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| test('triggers onChange', () => { | ||
| render(<PopoverDropdown {...defaultProps} />); | ||
| userEvent.click(screen.getByRole('button')); | ||
| expect(screen.getByText('Option 2')).toBeInTheDocument(); | ||
| userEvent.click(screen.getByText('Option 2')); | ||
| expect(defaultProps.onChange).toHaveBeenCalled(); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters