Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Adds storybook and tests to PopoverDropdown component #13547

Merged
merged 2 commits into from Mar 26, 2021
Merged

test: Adds storybook and tests to PopoverDropdown component #13547

merged 2 commits into from Mar 26, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Adds storybook and tests to PopoverDropdown component
  • Moves PopoverDropdown to its own folder
  • Converts PopoverDropdown to a functional component
  • Changes touched files to use full path imports

TEST PLAN

1 - Execute PopoverDropdown tests
2 - All tests should pass

@rusackas @junlincc

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc
Copy link
Member

@kgabryje Kamil, would you like to review?

@kgabryje
Copy link
Member

2 small nits, besides that LGTM!

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #13547 (d773277) into master (1d1a1cd) will decrease coverage by 3.71%.
The diff coverage is 40.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13547      +/-   ##
==========================================
- Coverage   77.31%   73.59%   -3.72%     
==========================================
  Files         903      603     -300     
  Lines       45926    21396   -24530     
  Branches     5624     5554      -70     
==========================================
- Hits        35508    15747   -19761     
+ Misses      10282     5515    -4767     
+ Partials      136      134       -2
Flag Coverage Δ
cypress 57.20% <25.64%> (+0.74%) ⬆️
javascript 63.41% <40.19%> (-0.07%) ⬇️
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/SqlLab/components/TemplateParamsEditor.jsx 23.80% <ø> (ø)
superset-frontend/src/common/components/index.tsx 100.00% <ø> (ø)
superset-frontend/src/components/Badge/index.tsx 100.00% <ø> (ø)
superset-frontend/src/components/Button/index.tsx 100.00% <ø> (ø)
...et-frontend/src/dashboard/actions/nativeFilters.ts 64.10% <0.00%> (-3.47%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 100.00% <ø> (+2.63%) ⬆️
...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx 40.90% <ø> (ø)
...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx 39.13% <0.00%> (-1.78%) ⬇️
...perset-frontend/src/dashboard/containers/Chart.jsx 100.00% <ø> (ø)
...erset-frontend/src/datasource/DatasourceEditor.jsx 66.38% <ø> (ø)
... and 322 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d1a1cd...9777dfd. Read the comment docs.

@junlincc
Copy link
Member

@kgabryje thanks for reviewing! it should be ready to go.

pkdotson
pkdotson approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L

@pkdotson pkdotson merged commit be8f8d9 into apache:master Mar 26, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@michael-s-molina
test: Adds storybook and tests to PopoverDropdown component (apache#1…
c8c754b 
…3547)

* test: Adds storybook and tests to PopoverDropdown component

* Changes to use gridUnit and theme hook
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje left review comments

@pkdotson pkdotson pkdotson approved these changes

@graceguo-supercat graceguo-supercat Awaiting requested review from graceguo-supercat

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L test:component 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@michael-s-molina @junlincc @kgabryje @pkdotson @mistercrunch