Improve comments on why derivedColumns is excluded for effect depende…

…ncies
apache · Nov 9, 2022 · c4eb12f · c4eb12f
1 parent 109feae
commit c4eb12f
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/superset-frontend/src/components/Table/index.tsx b/superset-frontend/src/components/Table/index.tsx
@@ -287,8 +287,12 @@ export function Table(props: TableProps) {
     return () => {
       interactiveTableUtils?.current?.clearListeners?.();
     };
+    /**
+     * We DO NOT want this effect to trigger when derivedColumns changes as it will break functionality
+     * The exclusion from the effect dependencies is intentional and should not be modified
+     */
     // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [wrapperRef, reorderable, resizable]);
+  }, [wrapperRef, reorderable, resizable, interactiveTableUtils]);
 
   const theme = useTheme();