Skip to content

Commit

Permalink
Improving logging around failed scheduled reports (#19924)
Browse files Browse the repository at this point in the history
  • Loading branch information
craig-rueda committed May 3, 2022
1 parent 90130e4 commit e1f53f2
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions superset/tasks/scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ def scheduler() -> None:

@celery_app.task(name="reports.execute")
def execute(report_schedule_id: int, scheduled_dttm: str) -> None:
task_id = None
try:
task_id = execute.request.id
scheduled_dttm_ = parser.parse(scheduled_dttm)
Expand All @@ -80,12 +81,14 @@ def execute(report_schedule_id: int, scheduled_dttm: str) -> None:
report_schedule_id,
scheduled_dttm_,
).run()
except ReportScheduleUnexpectedError as ex:
logger.error(
"An unexpected occurred while executing the report: %s", ex, exc_info=True
except ReportScheduleUnexpectedError:
logger.exception(
"An unexpected occurred while executing the report: %s", task_id
)
except CommandException:
logger.exception(
"A downstream exception occurred while generating" " a report: %s", task_id
)
except CommandException as ex:
logger.info("Report state: %s", ex)


@celery_app.task(name="reports.prune_log")
Expand All @@ -95,8 +98,4 @@ def prune_log() -> None:
except SoftTimeLimitExceeded as ex:
logger.warning("A timeout occurred while pruning report schedule logs: %s", ex)
except CommandException as ex:
logger.error(
"An exception occurred while pruning report schedule logs: %s",
ex,
exc_info=True,
)
logger.exception("An exception occurred while pruning report schedule logs")

0 comments on commit e1f53f2

Please sign in to comment.