adding a new database definition does not mask the password #1176
Comments
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 17, 2021
…1176) * fix(core): remove height and width requirement on SuperChart * simply by removing state
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 24, 2021
…1176) * fix(core): remove height and width requirement on SuperChart * simply by removing state
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 25, 2021
…1176) * fix(core): remove height and width requirement on SuperChart * simply by removing state
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 26, 2021
…1176) * fix(core): remove height and width requirement on SuperChart * simply by removing state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is another regression from PR #1137
Seen in master since that commit.
When adding a new database definition in '/databaseview/add' and including a sqlalchemy uri with a username and password, saving, then viewing the record, the password is included in the sqlalchemy uri and not password masked.
The fix is straightforward and I'll submit a PR soon. Apologies for this regression. Now I understand what
pre_addis for.The text was updated successfully, but these errors were encountered: