Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explore] Removing data from annotation layerdropdown causes modal dismiss #12475

Closed
1 task
adam-stasiak opened this issue Jan 12, 2021 · 0 comments · Fixed by #14221
Closed
1 task

[explore] Removing data from annotation layerdropdown causes modal dismiss #12475

adam-stasiak opened this issue Jan 12, 2021 · 0 comments · Fixed by #14221
Labels
explore:annotation Related to annotations in Explore

Comments

@adam-stasiak
Copy link
Contributor

Removing data from annotation layerdropdown causes modal dismiss

Expected results

modal should not be dismissed

Actual results

modal is dismissed

Screenshots

Nagranie.z.ekranu.2021-01-12.o.22.51.08.mov

How to reproduce the bug

Go to chart
Open add annotation layer area
Add annotation source
Remove annotation source

Environment

docker
on master I was not able to add any object to delete so I used branch and commit: f6446af

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • [x ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • [x ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
explore:annotation Related to annotations in Explore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants