fix(explore): fix clearing select data causes popover dismiss #14221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master change
Merge master
feat: merge master
Merge master
merge master
merge change
merge master
|
/testenv up |
|
@pkdotson Ephemeral environment spinning up at http://34.220.174.219:8080. Credentials are |
villebro
approved these changes
May 20, 2021
|
Ephemeral environment shutdown and build artifacts deleted. |
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…#14221) * fix(explore): fix clearing select data causes popover dismiss * wip: lint * wip: lint
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…#14221) * fix(explore): fix clearing select data causes popover dismiss * wip: lint * wip: lint
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…#14221) * fix(explore): fix clearing select data causes popover dismiss * wip: lint * wip: lint
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes the popover dismissed when clearing select data. The cause of this problem is because the clear icon of react-select will disappear after clicking, and the popover component of Antd will capture the mousedown event, this event will determine whether the current target exists under the parent component(here is document.body) , if it does not exist, the popover will be closed, and at this time the clear icon no longer exists.
All select components which set to
clearableunder popover will have the same problem. So here I passed theactionMetaproperty, if it is a clear event, the popover will not be closed.From another perspective, if the clear icon of react select always exists, this problem can be solved.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TEST PLAN
ADDITIONAL INFORMATION