IE 11 support #1339

gschrader · 2016-10-13T17:18:13Z

The urls that are created to fetch the json data seem to be formed wrong for IE in both the Dashboard and Slice views.

For example:

The IE url vs Chrome url . Looks like it's missing caravel/explore/table/3 as a prefix.

This was discussed in #1323.

The text was updated successfully, but these errors were encountered:

gschrader · 2016-10-13T17:19:39Z

I haven't tried earlier versions of IE, I shudder to think anyone still needing to support them. The new Edge browser in Windows 10 works great already.

mistercrunch · 2016-10-14T15:19:40Z

Does IE have weird issues with common URLs?

gschrader · 2016-10-14T15:49:51Z

@mistercrunch what do you mean by common URLs? I can navigate through all the pages within caravel just fine, it's just the visualizations that aren't fetching correctly.

woel0007 · 2016-11-14T20:47:57Z

Did anyone else make any progress with this issue? From what I can tell, it's still happening...

Steps to re-create:

I pulled the latest version of Superset from GH this AM. Commit: 2133056
Install/build node dependencies.
Started superset.

When tested via Chrome, everything seems to work just fine. However, when tested from IE11 (from the same machine used to test via Chrome) I see the same error from the screenshot above.

Note: Superset itself is not installed on Windows - I use my Windows machine only to test with different browsers. Superset is installed/running from OSX.

I did a little bit of troubleshooting - there's definitely a difference in the URLs being requested between Chrome and IE.

IE:

/superset/explore/druid/86/superset/explore_json/druid/86/?viz_type=table&granularity=one+day&druid_time_origin=&since=7+days+ago&until=now&table_timestamp_format=smart_date&row_limit=50000&include_search=false&flt_col_0=&flt_op_0=in&flt_eq_0=&having_col_0=&having_op_0=%3D%3D&having_eq_0=&slice_id=&slice_name=&collapsed_fieldsets=&action=&userid=2&goto_dash=false&datasource_name=Test.DBQL_Analysis_V3&datasource_id=86&datasource_type=druid&previous_viz_type=table&rdo_save=saveas&new_slice_name=&add_to_dash=false&save_to_dashboard_id=&new_dashboard_name=&json=true&force=false

Chrome:

/superset/explore_json/druid/86/?viz_type=table&granularity=one+day&druid_time_origin=&since=7+days+ago&until=now&table_timestamp_format=smart_date&row_limit=50000&include_search=false&flt_col_0=&flt_op_0=in&flt_eq_0=&having_col_0=&having_op_0=%3D%3D&having_eq_0=&slice_id=&slice_name=&collapsed_fieldsets=&action=&userid=2&goto_dash=false&datasource_name=Test.DBQL_Analysis_V3&datasource_id=86&datasource_type=druid&previous_viz_type=table&rdo_save=saveas&new_slice_name=&add_to_dash=false&save_to_dashboard_id=&new_dashboard_name=&json=true&force=false

If it isn't obvious from the above extremely-long URL, the only difference in the above URLs is that, in IE, the URL begins with /superset/explore/druid/86/; otherwise the 2 URLs are identical.

Any idea what could be causing this issue? Is there any other logs I can provide that might help to reproduce and/or diagnose?

woel0007 · 2016-11-27T02:00:35Z

Does anyone have any thoughts on this one? Why would IE write a different URL than Chrome/Safari?

gschrader · 2016-11-28T23:12:25Z

@woel0007 it doesn't make much sense to me why IE would behave differently, I haven't had a chance to look closer at the code yet though.

I do find it odd that @mistercrunch added the can't reproduce label, I think it is easily reproducible

mistercrunch · 2016-11-29T00:26:06Z

It's only easy to reproduce if you have access to a windows computer

gschrader · 2016-11-29T00:28:42Z

Yes true, having windows would be necessary. I've used https://github.com/xdissent/ievms in the past with success.

niconoe · 2016-12-05T16:49:28Z

Yep, I also have the issue with v0.14.0

francisliyy · 2016-12-09T01:42:32Z

is there any breakthrogh for this issue?

wbsljh · 2016-12-09T05:51:35Z

slice.jsonEndpoint() missing the '/' when you use ie 11 browser, so you can rewrite the jsonEndpotint

superset.js

jsonEndpoint() {
const parser = document.createElement('a');
parser.href = data.json_endpoint;
let endpoint = parser.pathname + this.querystring();
endpoint += '&json=true';
endpoint += '&force=' + this.force;
//for ie11
if (endpoint.substring(0, 1) != '/') {
endpoint = '/' + endpoint;
}
return endpoint;
},

xrmx · 2016-12-09T08:17:58Z

@wbsljh care to open a pull request please?

rlei · 2016-12-13T05:14:04Z

@xrmx we recently met the same issue and had fixed it in our local repo. I've created PR #1821 for it. Please have a review at it, thanks.

The issue is caused by a long standing IE issue. Superset's Slice.jsonEndpoint() method relies on DOM element's pathname() to build JSON API URL for slices, and in IE <= 11 the return value of out-of-document element lacks a leading '/'.

xrmx · 2016-12-13T08:37:06Z

@rlei thanks!

This should fix issue apache#1339. IE 11 and lower has a long standing issue: out-of-document element's pathname has no leading '/'. See https://connect.microsoft.com/IE/feedbackdetail/view/1002846/pathname-incorrect-for-out-of-document-elements And Superset's Slice.jsonEndpoint() method relies on pathname() to build JSON API URL for slices: ```javascript jsonEndpoint() { const parser = document.createElement('a'); parser.href = data.json_endpoint; let endpoint = parser.pathname + this.querystring(); endpoint += '&json=true'; endpoint += '&force=' + this.force; return endpoint; }, ``` `parser` above is exactly an out-of-document element. Therefore when running in IE <= 11, Superset would build wrong JSON endpoint URLs, hence the 404 errors for loading data for slices. This commit adds a simple workaround when leading '/' is missing in the value returned by pathname().

This should fix issue #1339. IE 11 and lower has a long standing issue: out-of-document element's pathname has no leading '/'. See https://connect.microsoft.com/IE/feedbackdetail/view/1002846/pathname-incorrect-for-out-of-document-elements And Superset's Slice.jsonEndpoint() method relies on pathname() to build JSON API URL for slices: ```javascript jsonEndpoint() { const parser = document.createElement('a'); parser.href = data.json_endpoint; let endpoint = parser.pathname + this.querystring(); endpoint += '&json=true'; endpoint += '&force=' + this.force; return endpoint; }, ``` `parser` above is exactly an out-of-document element. Therefore when running in IE <= 11, Superset would build wrong JSON endpoint URLs, hence the 404 errors for loading data for slices. This commit adds a simple workaround when leading '/' is missing in the value returned by pathname().

xrmx · 2016-12-28T09:21:18Z

PR is merged, closing.

apache#1355) This reverts commit 19f8f6a09c284de157c7179d43275ea2344b2372.

mistercrunch added #bug:cant-reproduce Bugs that cannot be reproduced windows labels Oct 14, 2016

xrmx added the help wanted label Dec 5, 2016

rlei mentioned this issue Dec 13, 2016

Workaround for slices "Not Found" issue in IE <= 11 #1821

Merged

xrmx closed this as completed Dec 28, 2016

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021

chore: isolate the one actual jquery dependency (apache#1339)

13f61b9

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021

Revert "chore: isolate the one actual jquery dependency (apache#1339)" (

64dca43

apache#1355) This reverts commit 19f8f6a09c284de157c7179d43275ea2344b2372.

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021

chore: isolate the one actual jquery dependency (apache#1339)

9184c2a

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021

Revert "chore: isolate the one actual jquery dependency (apache#1339)" (

09ccca3

apache#1355) This reverts commit 19f8f6a09c284de157c7179d43275ea2344b2372.

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021

chore: isolate the one actual jquery dependency (apache#1339)

ef84433

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021

Revert "chore: isolate the one actual jquery dependency (apache#1339)" (

248d479

apache#1355) This reverts commit 19f8f6a09c284de157c7179d43275ea2344b2372.

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021

chore: isolate the one actual jquery dependency (apache#1339)

c651171

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021

Revert "chore: isolate the one actual jquery dependency (apache#1339)" (

e1944cf

apache#1355) This reverts commit 19f8f6a09c284de157c7179d43275ea2344b2372.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IE 11 support #1339

IE 11 support #1339

gschrader commented Oct 13, 2016

gschrader commented Oct 13, 2016

mistercrunch commented Oct 14, 2016

gschrader commented Oct 14, 2016

woel0007 commented Nov 14, 2016 •

edited

woel0007 commented Nov 27, 2016

gschrader commented Nov 28, 2016

mistercrunch commented Nov 29, 2016

gschrader commented Nov 29, 2016

niconoe commented Dec 5, 2016

francisliyy commented Dec 9, 2016

wbsljh commented Dec 9, 2016 •

edited

xrmx commented Dec 9, 2016

rlei commented Dec 13, 2016 •

edited

xrmx commented Dec 13, 2016

xrmx commented Dec 28, 2016

IE 11 support #1339

IE 11 support #1339

Comments

gschrader commented Oct 13, 2016

gschrader commented Oct 13, 2016

mistercrunch commented Oct 14, 2016

gschrader commented Oct 14, 2016

woel0007 commented Nov 14, 2016 • edited

woel0007 commented Nov 27, 2016

gschrader commented Nov 28, 2016

mistercrunch commented Nov 29, 2016

gschrader commented Nov 29, 2016

niconoe commented Dec 5, 2016

francisliyy commented Dec 9, 2016

wbsljh commented Dec 9, 2016 • edited

xrmx commented Dec 9, 2016

rlei commented Dec 13, 2016 • edited

xrmx commented Dec 13, 2016

xrmx commented Dec 28, 2016

woel0007 commented Nov 14, 2016 •

edited

wbsljh commented Dec 9, 2016 •

edited

rlei commented Dec 13, 2016 •

edited