Workaround for slices "Not Found" issue in IE <= 11 #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@mistercrunch @vera-liu created an issue to make sure this works in v2 #1831 |
|
@rlei could you please rebase on top of master? |
This should fix issue apache#1339. IE 11 and lower has a long standing issue: out-of-document element's pathname has no leading '/'. See https://connect.microsoft.com/IE/feedbackdetail/view/1002846/pathname-incorrect-for-out-of-document-elements And Superset's Slice.jsonEndpoint() method relies on pathname() to build JSON API URL for slices: ```javascript jsonEndpoint() { const parser = document.createElement('a'); parser.href = data.json_endpoint; let endpoint = parser.pathname + this.querystring(); endpoint += '&json=true'; endpoint += '&force=' + this.force; return endpoint; }, ``` `parser` above is exactly an out-of-document element. Therefore when running in IE <= 11, Superset would build wrong JSON endpoint URLs, hence the 404 errors for loading data for slices. This commit adds a simple workaround when leading '/' is missing in the value returned by pathname().
|
@xrmx sure just rebased. |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #1339.
IE 11 and lower have a long standing issue: out-of-document element's
pathname has no leading '/'. See Pathname incorrect for out-of-document elements at Microsoft side (it's marked as fixed but apparently not...).
And Superset's
Slice.jsonEndpoint()method relies onpathname()to buildJSON API URL for slices:
parserabove is exactly an out-of-document element. Therefore whenrunning in IE <= 11, Superset would build wrong JSON endpoint URLs,
hence the 404 errors for loading data for slices.
This commit adds a simple workaround when leading '/' is missing in the
value returned by pathname().