Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x-filtering]resizing window should not trigger query on dashboard #14696

Closed
junlincc opened this issue May 18, 2021 · 0 comments · Fixed by #15172
Closed

[x-filtering]resizing window should not trigger query on dashboard #14696

junlincc opened this issue May 18, 2021 · 0 comments · Fixed by #15172
Assignees
@kgabryje
Labels
#bug Bug report dashboard:cross-filters Related to the Dashboard cross filters P2 Priority item - High
Projects
Native dashboard filters

Comments

@junlincc
Copy link
Member

junlincc commented May 18, 2021 •
edited

Both View query and and X-filerting are not fully available yet, but we should address below before rolling out the feature

As we can see in the "View query" modal, all charts in dashboard reload on window resize which causes performance issues:
Resizing

Screen.Recording.2021-05-18.at.12.14.49.PM.mov
@junlincc junlincc added the #bug Bug report label May 18, 2021
@junlincc junlincc mentioned this issue May 18, 2021
Merged
8 tasks
@junlincc junlincc added dashboard:cross-filters Related to the Dashboard cross filters P2 Priority item - High labels May 18, 2021
@junlincc junlincc added this to To do in Native dashboard filters via automation Jun 2, 2021
@kgabryje kgabryje self-assigned this Jun 15, 2021
@kgabryje kgabryje moved this from To do to In progress in Native dashboard filters Jun 15, 2021
@kgabryje kgabryje mentioned this issue Jun 15, 2021
Merged
8 tasks
@kgabryje kgabryje moved this from In progress to In review in Native dashboard filters Jun 15, 2021
Native dashboard filters automation moved this from In review to Done Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgabryje kgabryje

Labels
#bug Bug report dashboard:cross-filters Related to the Dashboard cross filters P2 Priority item - High
Projects
No open projects
Native dashboard filters
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dashboard): Prevent rerendering View Query modal on window resize kgabryje/incubator-superset
3 participants
@kgabryje @amitmiran137 @junlincc