Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard): View query of the chart in dashboard #14667

Merged
merged 7 commits into from May 18, 2021
Merged

feat(dashboard): View query of the chart in dashboard #14667

merged 7 commits into from May 18, 2021

Conversation

m-ajay
Copy link
Contributor

@m-ajay m-ajay commented May 17, 2021

SUMMARY

Lets the user view query used to generate the chart from the dashboard.

BEFORE/AFTER SCREENSHOTS

View Query in the menu option
View Query in the menu
View the query
Viewing query in the Modal

TEST PLAN

Manual and CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc
Copy link
Member

junlincc commented May 17, 2021 •
edited

thanks for the improvement!! this is great! @m-ajay does the query get updated when filters are applied?

@junlincc
Copy link
Member

/testenv up

@m-ajay
Copy link
Contributor Author

m-ajay commented May 17, 2021

@junlincc Yes, it respects the filters applied in dashboard.

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #14667 (1a2a5b3) into master (4f5c537) will increase coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14667   +/-   ##
=======================================
  Coverage   77.54%   77.54%           
=======================================
  Files         958      959    +1     
  Lines       48541    48552   +11     
  Branches     5702     5708    +6     
=======================================
+ Hits        37640    37650   +10     
- Misses      10700    10702    +2     
+ Partials      201      200    -1
Flag Coverage Δ
javascript 72.52% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/dashboard/components/gridComponents/Chart.jsx 81.18% <ø> (ø)
...src/explore/components/controls/ViewQueryModal.tsx 76.92% <76.92%> (ø)
...end/src/dashboard/components/SliceHeader/index.tsx 92.00% <100.00%> (ø)
...dashboard/components/SliceHeaderControls/index.jsx 73.78% <100.00%> (+0.51%) ⬆️
...nd/src/explore/components/ExploreActionButtons.tsx 71.73% <100.00%> (-0.61%) ⬇️
.../components/ExploreAdditionalActionsMenu/index.jsx 100.00% <100.00%> (ø)
...nd/src/explore/components/ExploreViewContainer.jsx 2.32% <0.00%> (-0.02%) ⬇️
...uperset-frontend/src/components/Menu/MenuRight.tsx 93.18% <0.00%> (ø)
...mponents/controls/MetricControl/MetricsControl.jsx 82.45% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5c537...1a2a5b3. Read the comment docs.

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://54.245.153.87:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@junlincc junlincc added hold:testing! On hold for testing need:qa-review Requires QA review labels May 17, 2021
graceguo-supercat
graceguo-supercat approved these changes May 18, 2021
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junlincc
Copy link
Member

Screen Shot 2021-05-18 at 11 54 48 AM

Screen Shot 2021-05-18 at 11 56 06 AM

it respect both native filter and x filtering events. thank you much! good to go!!

@junlincc junlincc added need:merge The PR is ready to be merged release:note demo and removed hold:testing! On hold for testing need:qa-review Requires QA review labels May 18, 2021
@junlincc
Copy link
Member

@m-ajay #14696 im not sure if it's related?

@junlincc junlincc removed the need:merge The PR is ready to be merged label May 18, 2021
@pkdotson pkdotson merged commit 84e8dc7 into apache:master May 18, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@m-ajay
Copy link
Contributor Author

m-ajay commented May 19, 2021

@junlincc I don't think it's related to this issue. Seems like a separate issue.

@junlincc junlincc removed the demo label May 28, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@m-ajay
feat(dashboard): View query of the chart in dashboard (apache#14667)
b49471e 
* Extract view query component out

* Typo correction

* Fix and rename tests

* Remove logs, and test code

* Rename file - fix tests

* Fix a typo

* Linting errors, add Apache License Header
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@m-ajay
feat(dashboard): View query of the chart in dashboard (apache#14667)
206bdfe 
* Extract view query component out

* Typo correction

* Fix and rename tests

* Remove logs, and test code

* Rename file - fix tests

* Fix a typo

* Linting errors, add Apache License Header
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@m-ajay
feat(dashboard): View query of the chart in dashboard (apache#14667)
d597d55 
* Extract view query component out

* Typo correction

* Fix and rename tests

* Remove logs, and test code

* Rename file - fix tests

* Fix a typo

* Linting errors, add Apache License Header
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

@junlin-qa junlin-qa junlin-qa approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels release:note size/L 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@m-ajay @junlincc @graceguo-supercat @junlin-qa @mistercrunch @pkdotson