fix(dashboard): Prevent rerendering View Query modal on window resize #15172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
approved these changes
Jun 15, 2021
| @@ -16,7 +16,7 @@ | |||
| * specific language governing permissions and limitations | |||
| * under the License. | |||
| */ | |||
| import React, { useEffect, useState } from 'react'; | |||
| import React, { useEffect, useState, useCallback } from 'react'; | |||
There was a problem hiding this comment.
This doesn't appear to be needed here?
There was a problem hiding this comment.
Ugh, forgot to remove it. Thanks!
Codecov Report
@@ Coverage Diff @@
## master #15172 +/- ##
==========================================
- Coverage 77.41% 77.25% -0.17%
==========================================
Files 969 969
Lines 49999 50011 +12
Branches 6424 6431 +7
==========================================
- Hits 38705 38634 -71
- Misses 11091 11174 +83
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…apache#15172) * fix(dashboard): Prevent rerendering View Query modal on window resize * Fix lint
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…apache#15172) * fix(dashboard): Prevent rerendering View Query modal on window resize * Fix lint
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…apache#15172) * fix(dashboard): Prevent rerendering View Query modal on window resize * Fix lint
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Due to using a complex javascript object in
useEffect's dependency array inViewQueryModal, we were rerunning API request on every rerender of the modal (including resizing window). I fixed it by usingJSON.stringifymethod in the dependency array.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: see #14696
After:
https://user-images.githubusercontent.com/15073128/122034659-070c3980-cdd2-11eb-8617-6650cf4b3c43.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC: @junlincc