Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing multiple refresh bug in filter_box #171

Merged
merged 1 commit into from
Mar 8, 2016
Merged

Conversation

mistercrunch
Copy link
Member

Addresses #170

@williaster, cranking up the lint max-params for functions to accept 4 params as it's acceptable in many cases. This allows us to be 100% lint free.

@williaster
Copy link
Contributor

sgtm, jordan's original lint file had it set to 2 which seems a little conservative ... I like 4 :)

👍

mistercrunch added a commit that referenced this pull request Mar 8, 2016
Fixing multiple refresh bug in filter_box
@mistercrunch mistercrunch merged commit 91833ce into master Mar 8, 2016
@mistercrunch mistercrunch deleted the fix_filter branch March 8, 2016 12:29
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
* feat: add parseLength function

* feat: export

* fix: address Kim's comment
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
* feat: add parseLength function

* feat: export

* fix: address Kim's comment
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
* feat: add parseLength function

* feat: export

* fix: address Kim's comment
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
* feat: add parseLength function

* feat: export

* fix: address Kim's comment
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
* feat: add parseLength function

* feat: export

* fix: address Kim's comment
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants