fix(select): render when empty multiselect

[villebro]

SUMMARY

PR #19341 introduced a regression that caused the adhoc filter value selector to disappear if a multioperator (IN, NOT IN) was chosen and there were no options. It is typical for the options to be missing if the "populate autocomplete filters options" option has been disabled in the dataset properties. I believe the reason for the bug that #19341 attempted to address was due to only checking if a selected item was typeof 'object'. This is true for null, which caused the logic to assume the value was in fact a LabeledValue (=object with keys value and label). Here we introduce a typeguard to make the checking even more robust, and remove the logic that delays rendering of SelectWithLabel.

I checked that the original issue that #19341 set out to fix still works after this change. However, deselecting a NULL value doesn't seem to work properly if there are other falsy values (for this we'll need to use LabeledValue and use a custom key as do make sure each entry is unique). However, I consider this a separate issue which should be addressed in the native filter, so will address that in a separate PR.

AFTER

Now the dropdown renders correctly:

filter-after.mp4

BEFORE

Previously the dropdown disappeared if there were no options:

filter-before2.mp4

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

1. Disable "populate autocomplete filters options" in a dataset
2. Explore the dataset and add an adhoc filter
3. choose any column and choose the "IN" operator
4. see the dropdown disappear

ADDITIONAL INFORMATION

• Has associated issue: closes Adhoc filter popover simple tab on explore view does not render subject multi select if no suggestions are present #19592
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #19612 (0d8d080) into master (761d5c4) will decrease coverage by 0.15%.
The diff coverage is 87.50%.

❗ Current head 0d8d080 differs from pull request most recent head c16c534. Consider uploading reports for the commit c16c534 to get more accurate results

@@            Coverage Diff             @@
##           master   #19612      +/-   ##
==========================================
- Coverage   66.68%   66.53%   -0.16%     
==========================================
  Files        1681     1681              
  Lines       64316    64319       +3     
  Branches     6565     6564       -1     
==========================================
- Hits        42888    42793      -95     
- Misses      19733    19853     +120     
+ Partials     1695     1673      -22     

Flag	Coverage Δ
javascript	51.21% <87.50%> (-0.30%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx	65.60% <ø> (+0.52%)	⬆️
superset-frontend/src/components/Select/Select.tsx	87.28% <83.33%> (+0.36%)	⬆️
superset-frontend/src/components/Select/utils.ts	65.00% <100.00%> (+1.84%)	⬆️
...ts/nativeFilters/FilterBar/FilterControls/state.ts	0.00% <0.00%> (-75.00%)	⬇️
...veFilters/FilterBar/FilterControls/FilterValue.tsx	6.59% <0.00%> (-53.85%)	⬇️
...tend/src/filters/components/Time/transformProps.ts	0.00% <0.00%> (-50.00%)	⬇️
...oard/components/nativeFilters/FilterCard/index.tsx	10.00% <0.00%> (-50.00%)	⬇️
...d/src/filters/components/Time/TimeFilterPlugin.tsx	0.00% <0.00%> (-47.06%)	⬇️
...Filters/FilterBar/FilterControls/FilterControl.tsx	29.03% <0.00%> (-41.94%)	⬇️
...rset-frontend/src/filters/components/Time/index.ts	66.66% <0.00%> (-33.34%)	⬇️
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 761d5c4...c16c534. Read the comment docs.