You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the explore view for a dataset there are a set of conditions which causes the the subject select to not render in the adhoc filter pop over control (AdhocFilterEditPopoverSimpleTabContent) . These condition are met when a column is selected and an operator belonging to the MULTI_OPERATORS list has also been selected and no suggestions have been populated.
I believe this to be caused by this line here this seems to cause the behaviour that if you have a MULTI_OPERATOR and no suggestions the select will not render. The intention seems to be to delay rendering until suggestions are loaded, however there are cases where the suggestions will never load in some of our datasets.
If this is not intended behaviour I would also be more than happy to take a look and attempt a fix.
How to reproduce the bug
The bug is data source dependent but here are some steps to create a simple fake dataset that this bug will appear in
SQL Lab and input a query such as select 1 as col1, 2 as col2, 3 as col3
Save this query as a virtual dataset by clicking the explore button
Open the dataset in the explore view
click on filters to open the popover
select any col (col1, col2, col3) and select the IN operator
The multislect for the subject will not render
OR
Disable suggestions on a dataset
repeat steps 3-6
Expected results
The multi select would render even if there are no suggestions loaded.
Actual results
The subject multi select does not render.
Screenshots
Environment
browser: Firefox
superset version: superset master branch and 1.5.0rc1
python version: python 3.8.10
node.js version: v16.13.0
Checklist
Make sure to follow these steps before submitting your issue - thank you!
I have checked the superset logs for python stacktraces and included it here as text if there are any.
I have not reproduced the issue with at least the latest released version of superset. however I have reproduced it for 1.5.0rc1
I have checked the issue tracker for the same issue and I haven't found one similar.
The text was updated successfully, but these errors were encountered:
In the explore view for a dataset there are a set of conditions which causes the the subject select to not render in the adhoc filter pop over control (AdhocFilterEditPopoverSimpleTabContent) . These condition are met when a column is selected and an operator belonging to the MULTI_OPERATORS list has also been selected and no suggestions have been populated.
I believe this to be caused by this line here this seems to cause the behaviour that if you have a MULTI_OPERATOR and no suggestions the select will not render. The intention seems to be to delay rendering until suggestions are loaded, however there are cases where the suggestions will never load in some of our datasets.
If this is not intended behaviour I would also be more than happy to take a look and attempt a fix.
How to reproduce the bug
The bug is data source dependent but here are some steps to create a simple fake dataset that this bug will appear in
select 1 as col1, 2 as col2, 3 as col3
OR
Expected results
The multi select would render even if there are no suggestions loaded.
Actual results
The subject multi select does not render.
Screenshots
Environment
Checklist
Make sure to follow these steps before submitting your issue - thank you!
The text was updated successfully, but these errors were encountered: