Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Null values on Explore filter #19341

Merged
merged 1 commit into from
Mar 23, 2022
Merged

fix: Null values on Explore filter #19341

merged 1 commit into from
Mar 23, 2022

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes NULL values on Explore filter control.

Fixes #19264

BEFORE/AFTER SCREENSHOTS

null.value.on.explore.mov
Screen.Recording.2022-03-23.at.4.50.43.PM.mov

TESTING INSTRUCTIONS

Check the video for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

rusackas
rusackas approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix! Will test on an ephemeral build before merging.

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://54.187.50.69:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@srinify srinify merged commit 65c204b into apache:master Mar 23, 2022
@rusackas
Copy link
Member

Tests well! Merging!

@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 23, 2022
@michael-s-molina @sadpandajoe
fix: Null values on Explore filter (apache#19341)
822993a 
(cherry picked from commit 65c204b)
@sadpandajoe
Copy link
Contributor

🏷️ preset:2022.11

villebro pushed a commit that referenced this pull request Apr 3, 2022
@michael-s-molina @villebro
fix: Null values on Explore filter (#19341)
a81b1ab 
(cherry picked from commit 65c204b)
@villebro
Copy link
Member

villebro commented Apr 8, 2022

This appears to have caused a regression: #19592

@villebro villebro mentioned this pull request Apr 8, 2022
Merged
9 tasks
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@michael-s-molina @philipher29
fix: Null values on Explore filter (apache#19341)
854e7b4
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@geido geido geido approved these changes

@zhaoyongjie zhaoyongjie Awaiting requested review from zhaoyongjie

@jinghua-qa jinghua-qa Awaiting requested review from jinghua-qa

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset:2022.11 size/M 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native Filter can't work when face NULL value or empty string
7 participants
@michael-s-molina @rusackas @sadpandajoe @villebro @geido @mistercrunch @srinify