fix: columns are lost when dashboard to explore #20699
Conversation
| @@ -55,8 +55,7 @@ export const hydrateExplore = | |||
| if (dashboardId) { | |||
| initialFormData.dashboardId = dashboardId; | |||
| } | |||
| const initialDatasource = | |||
| datasources?.[initialFormData.datasource] ?? dataset; | |||
| const initialDatasource = dataset; | |||
There was a problem hiding this comment.
fallbackExploreInitialData handle this case. There should be some refactoring going on here, so keep this variable for now.
Codecov Report
@@ Coverage Diff @@
## master #20699 +/- ##
==========================================
- Coverage 66.84% 66.83% -0.01%
==========================================
Files 1750 1750
Lines 65890 65894 +4
Branches 7016 7017 +1
==========================================
Hits 44041 44041
- Misses 20063 20067 +4
Partials 1786 1786
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Pushed a fix - we shouldn't check if slice is null. It is expected that slice is null when user creates a new chart |
zhaoyongjie
force-pushed
the
fix/dashboard_to_explore
branch
from
e90199a
to
52ce1bf
Compare
| @@ -28,7 +28,7 @@ import { HEALTH_POP_FORM_DATA_DEFAULTS } from './visualizations/shared.helper'; | |||
| const apiURL = (endpoint: string, queryObject: Record<string, unknown>) => | |||
| `${endpoint}?q=${rison.encode(queryObject)}`; | |||
|
|
|||
| describe('Test explore links', () => { | |||
| describe.skip('Test explore links', () => { | |||
There was a problem hiding this comment.
temporarily skip this test, will reenable after the PR.
mistercrunch
added
🏷️ bot
SUMMARY
Currently, columns of datasource are lost when switching from Dashboard to the Explore page.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
dashboard.to.explore.mov
Before
dashboard.to.explore.before.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION