Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Türkiye Map to Country Map #20801

Merged
merged 2 commits into from
Jul 23, 2022

Conversation

rizacavus
Copy link
Contributor

SUMMARY

Add Türkiye Map to Country Map

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

175822046-09a5d9b7-f781-4910-b3fb-630b384eece1

TESTING INSTRUCTIONS

Clone the repo and go to its root directory. Run the following shell commands:

cd superset-frontend && npm install
npm run plugins:storybook

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rizacavus rizacavus changed the title Add Türkiye Map to Country Map feat: Add Türkiye Map to Country Map Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #20801 (f53b218) into master (290b89c) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #20801      +/-   ##
==========================================
- Coverage   66.80%   66.78%   -0.02%     
==========================================
  Files        1754     1753       -1     
  Lines       65572    66023     +451     
  Branches     6933     7059     +126     
==========================================
+ Hits        43804    44094     +290     
- Misses      20014    20131     +117     
- Partials     1754     1798      +44     
Flag Coverage Δ
javascript 51.98% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <ø> (ø)
...t-frontend/src/dashboard/containers/SliceAdder.jsx 0.00% <0.00%> (-100.00%) ⬇️
...rontend/src/dashboard/containers/DashboardGrid.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/utils/getDatasourceUid.ts 50.00% <0.00%> (-50.00%) ⬇️
superset-frontend/src/featureFlags.ts 66.66% <0.00%> (-33.34%) ⬇️
...rset-frontend/src/explore/components/SaveModal.tsx 36.47% <0.00%> (-29.73%) ⬇️
superset-frontend/src/components/Select/Select.tsx 67.78% <0.00%> (-19.67%) ⬇️
...i-chart-controls/src/shared-controls/constants.tsx 18.75% <0.00%> (-18.75%) ⬇️
superset-frontend/src/views/store.ts 65.00% <0.00%> (-15.00%) ⬇️
...t-frontend/src/dashboard/components/SliceAdder.jsx 62.66% <0.00%> (-13.81%) ⬇️
... and 136 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@zhaoyongjie zhaoyongjie self-requested a review July 22, 2022 09:08
@@ -154,6 +156,9 @@ export const countryOptions = Object.keys(countries).map(x => {
if (x === 'italy_regions') {
return [x, 'Italy (regions)'];
}
if (x === 'turkey') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution. might we keep the country name as English(Because many users cannot input non-ascii characters)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was actually like that, but asked to changed to Türkiye on #20698 and waits for review for 5 days :/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the waiting long time. I have approved. just waiting for the CI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srinify could we keep the country name in English?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed it to Turkey

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test it on the master branch, looks great! just left a suggestion. other lgtm

image

@zhaoyongjie zhaoyongjie merged commit 4ffa3c2 into apache:master Jul 23, 2022
rizacavus added a commit to rizacavus/incubator-superset that referenced this pull request Sep 23, 2022
Turkey map already added with "feat: Add Türkiye Map to Country Map apache#20801"
@rizacavus rizacavus mentioned this pull request Sep 23, 2022
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants