feat(embedded): provides filter bar visibility setting on embedded dashboard (#21069)

[jileeon]

SUMMARY

Provides filter bar visibility setting on embedded dashboards

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue: fix(dashboard): fix default filter bar visibility + add docs #18741

[michael-s-molina]

Thanks for the contribution @jileeon.

@lilykuang Do you think it makes sense to add these configurations under dashboardUiConfig? Something like:

dashboardUiConfig: {
   hideTitle: true,
   filters: {
      visible: true,
      expanded: true,
   }
}

[lilykuang]

@michael-s-molina you suggestion will work better.

[jileeon]

Hi @michael-s-molina,

I've changed the commit for your suggestion.

Thanks

[jileeon]

Hi, Sorry for the wrong constant values. I've corrected it now.
Please check the source code changes.

Thanks.

[jayakrishnankk]

@jileeon - considering DASHBOARD_UI_FILTER_CONFIG_URL_PARAM_KEY only has 2 keys namely visible and expanded and line number 115 does DASHBOARD_UI_FILTER_CONFIG_URL_PARAM_KEY[key]=filterConfig[key], i don't understand why there is a need for line number 41 ([key: string]: boolean | undefined) in the code.

I found this code while I was trying to add some additional capability add some extra url parameters to the embedded superset. But I don't want to add that code if the functionality already exist.

[jileeon]

Hi @jayakrishnankk, Sorry for the late reply.

these code you wrote are just for complying with Typescript lint.
I think there are no need to keep them If they should be changed.

Thanks.