Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(embedded): +2 functions: getDashboardPermalink, getActiveTabs #21444

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

jayakrishnankk
Copy link
Contributor

Added 2 more functions in embedded superset: getDashboardPermalinkForAnchor, getActiveTabs

SUMMARY

Ability to request the following information from the parent app to embedded superset

  • Get active tabs
  • Get dashboard permalink by anchor (example of an anchor - a chart id, for example CHART-a4qv8d)

TESTING INSTRUCTIONS

Embed dashboard using embedded sdk
Make calls to get active tabs
Make calls to get a chart permalink

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: EMBEDDED_SUPERSET = True
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@jayakrishnankk jayakrishnankk changed the title feat(embedded): +2 functions: getDashboardPermalinkForAnchor, getActiveTabs feat(embedded): +2 functions: getDashboardPermalink, getActiveTabs Sep 12, 2022
@jayakrishnankk jayakrishnankk force-pushed the jk/embedded-enhancements branch 2 times, most recently from 44016a6 to 8b7b769 Compare September 12, 2022 21:21
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #21444 (09ce85a) into master (9c285da) will increase coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #21444      +/-   ##
==========================================
+ Coverage   66.53%   66.61%   +0.07%     
==========================================
  Files        1791     1796       +5     
  Lines       68599    68660      +61     
  Branches     7320     7314       -6     
==========================================
+ Hits        45645    45738      +93     
+ Misses      21064    21060       -4     
+ Partials     1890     1862      -28     
Flag Coverage Δ
javascript 52.92% <0.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/embedded/api.tsx 0.00% <0.00%> (ø)
superset-frontend/src/embedded/index.tsx 0.00% <0.00%> (ø)
...iews/CRUD/data/dataset/AddDataset/Footer/index.tsx 33.33% <0.00%> (-66.67%) ⬇️
...frontend/src/components/ListView/Filters/index.tsx 52.17% <0.00%> (-14.50%) ⬇️
.../plugin-chart-pivot-table/src/plugin/buildQuery.ts 42.85% <0.00%> (-12.70%) ⬇️
...iews/CRUD/data/dataset/AddDataset/Header/index.tsx 87.50% <0.00%> (-12.50%) ⬇️
.../legacy-plugin-chart-histogram/src/controlPanel.ts 40.00% <0.00%> (-10.00%) ⬇️
.../BigNumber/BigNumberWithTrendline/controlPanel.tsx 16.66% <0.00%> (-8.34%) ⬇️
...ontend/src/explore/controlUtils/getControlState.ts 85.24% <0.00%> (-5.50%) ⬇️
...ntend/plugins/plugin-chart-table/src/buildQuery.ts 56.25% <0.00%> (-4.77%) ⬇️
... and 74 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nytai nytai merged commit b787c3f into apache:master Sep 29, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants