Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(embedded): +2 fns: getDashboardPermalink, getActiveTabs -> 1.5 #21552

Closed
wants to merge 3 commits into from

Conversation

jayakrishnankk
Copy link
Contributor

Added 2 more functions in embedded superset: getDashboardPermalinkForAnchor, getActiveTabs.
This is to merge these changes to 1.5 branch of superset.

This pull request includes cherry-picked changes from #21444

SUMMARY

Ability to request the following information from the parent app to embedded superset

Get active tabs
Get dashboard permalink by anchor (example of an anchor - a chart id, for example CHART-a4qv8d)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Embed dashboard using embedded sdk
Make calls to get active tabs
Make calls to get a chart permalink

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: EMBEDDED_SUPERSET = True
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@jayakrishnankk jayakrishnankk changed the title feat(embedded): +2 functions: getDashboardPermalink, getActiveTabs feat(embedded): +2 fns: getDashboardPermalink, getActiveTabs -> 1.5 Sep 22, 2022
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #21552 (571561e) into 1.5 (0c05300) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##              1.5   #21552      +/-   ##
==========================================
- Coverage   66.75%   66.73%   -0.02%     
==========================================
  Files        1690     1690              
  Lines       65186    65187       +1     
  Branches     6555     6555              
==========================================
- Hits        43515    43503      -12     
- Misses      19983    19996      +13     
  Partials     1688     1688              
Flag Coverage Δ
hive 52.36% <0.00%> (-0.01%) ⬇️
mysql ?
postgres 82.07% <100.00%> (+<0.01%) ⬆️
presto 52.22% <0.00%> (-0.01%) ⬇️
python 82.44% <100.00%> (-0.04%) ⬇️
sqlite 81.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/embedded/index.tsx 0.00% <0.00%> (ø)
superset/security/guest_token.py 97.56% <100.00%> (+0.06%) ⬆️
superset/common/utils/dataframe_utils.py 85.71% <0.00%> (-7.15%) ⬇️
superset/db_engine_specs/mysql.py 93.97% <0.00%> (-3.62%) ⬇️
superset/models/core.py 88.33% <0.00%> (-0.72%) ⬇️
superset/views/core.py 75.50% <0.00%> (-0.43%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jayakrishnankk
Copy link
Contributor Author

Since 1.5.x is in security patch only mode, closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants