-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(embedded): +2 functions: getDashboardPermalink, getActiveTabs #21444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayakrishnankk
force-pushed
the
jk/embedded-enhancements
branch
from
September 12, 2022 21:19
5728be4
to
7d87fab
Compare
jayakrishnankk
changed the title
feat(embedded): +2 functions: getDashboardPermalinkForAnchor, getActiveTabs
feat(embedded): +2 functions: getDashboardPermalink, getActiveTabs
Sep 12, 2022
jayakrishnankk
force-pushed
the
jk/embedded-enhancements
branch
2 times, most recently
from
September 12, 2022 21:21
44016a6
to
8b7b769
Compare
jayakrishnankk
force-pushed
the
jk/embedded-enhancements
branch
from
September 21, 2022 14:04
8b7b769
to
8691704
Compare
jayakrishnankk
force-pushed
the
jk/embedded-enhancements
branch
from
September 21, 2022 15:59
8691704
to
94db0a6
Compare
lilykuang
approved these changes
Sep 21, 2022
9 tasks
jayakrishnankk
force-pushed
the
jk/embedded-enhancements
branch
from
September 27, 2022 23:16
52edd4c
to
09ce85a
Compare
Codecov Report
@@ Coverage Diff @@
## master #21444 +/- ##
==========================================
+ Coverage 66.53% 66.61% +0.07%
==========================================
Files 1791 1796 +5
Lines 68599 68660 +61
Branches 7320 7314 -6
==========================================
+ Hits 45645 45738 +93
+ Misses 21064 21060 -4
+ Partials 1890 1862 -28
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mistercrunch
added
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 2.1.0
and removed
🚢 2.1.3
labels
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 more functions in embedded superset: getDashboardPermalinkForAnchor, getActiveTabs
SUMMARY
Ability to request the following information from the parent app to embedded superset
TESTING INSTRUCTIONS
Embed dashboard using embedded sdk
Make calls to get active tabs
Make calls to get a chart permalink
ADDITIONAL INFORMATION