Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-chart-table: Chart looses customization on save #21502

Closed
3 tasks done
mayurnewase opened this issue Sep 17, 2022 · 6 comments · Fixed by #23137
Closed
3 tasks done

plugin-chart-table: Chart looses customization on save #21502

mayurnewase opened this issue Sep 17, 2022 · 6 comments · Fixed by #23137
Labels
#bug Bug report viz:charts:table Related to the Table chart

Comments

@mayurnewase
Copy link
Contributor

mayurnewase commented Sep 17, 2022

A clear and concise description of what the bug is.

When table chart is saved with conditional formatting, it reloads the page without those customizations.
But after reloading it again correctly sets the customizations.

How to reproduce the bug

  1. create table chart on any data
  2. in customize tab, add conditional formatting on any column
  3. click on save
  4. see colors disappear
  5. reload the page again, should show colors in the cell correctly.

Expected results

what you expected to happen.

Actual results

what actually happens.

Screenshots

Screencast.from.17-09-22.03.07.57.PM.IST.webm

If applicable, add screenshots to help explain your problem.

Environment

(please complete the following information):

  • browser type and version: crome
  • superset version: latest master (last commit sha: 8c16806)
  • python version: 3.9
  • node.js version: 16.13.1
  • any feature flags active: no

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@mayurnewase mayurnewase added #bug Bug report viz:charts:table Related to the Table chart labels Sep 17, 2022
@Always-prog
Copy link
Contributor

Hello @mayurnewase!
Do Superset have any updates on this problem? I'll try to fix it.

@Always-prog
Copy link
Contributor

Hello!
I created fix for it #23137.

@Shazad-khan
Copy link

image

This issue has been fixed please close this issue

@Always-prog
Copy link
Contributor

Always-prog commented Mar 16, 2023

@Shazad-khan Hello!
Can you share commit/PR with fix of this issue please?

@Shazad-khan
Copy link

i haven't fixed it i just tested this issue in the latest version and i haven't found any issue.

@Always-prog
Copy link
Contributor

Strange, I tested the latest version of Superset and bug is still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report viz:charts:table Related to the Table chart
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants