fix(conditional formatting): controls looses on save

[Always-prog]

SUMMARY

Fixes #21502

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

looses-when-save.mp4

After

fix-looses-when-save.mp4

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue: Fixes plugin-chart-table: Chart looses customization on save #21502
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[Always-prog]

@villebro Hello!
Can anyone from Superset review my fix?

[villebro]

@Always-prog sorry for not getting to this sooner - are you able to rebase this PR?

[Always-prog]

@villebro Yes, I'll rebase it today

[codecov]

Codecov Report

Merging #23137 (c71b11a) into master (0cebe8b) will decrease coverage by 11.17%.
The diff coverage is 57.89%.

❗ Current head c71b11a differs from pull request most recent head 5864984. Consider uploading reports for the commit 5864984 to get more accurate results

@@             Coverage Diff             @@
##           master   #23137       +/-   ##
===========================================
- Coverage   67.65%   56.48%   -11.17%     
===========================================
  Files        1910     1914        +4     
  Lines       73745    73927      +182     
  Branches     7987     8021       +34     
===========================================
- Hits        49891    41759     -8132     
- Misses      21813    30125     +8312     
- Partials     2041     2043        +2     

Flag	Coverage Δ
javascript	53.89% <52.54%> (+0.04%)	⬆️
mysql	?
postgres	?
sqlite	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...t-ui-chart-controls/src/shared-controls/mixins.tsx	16.66% <ø> (ø)
.../packages/superset-ui-core/src/chart/types/Base.ts	100.00% <ø> (ø)
...s/superset-ui-core/src/components/SafeMarkdown.tsx	66.66% <ø> (ø)
...gins/legacy-plugin-chart-world-map/src/WorldMap.js	0.00% <0.00%> (ø)
...plugins/legacy-plugin-chart-world-map/src/index.js	66.66% <ø> (ø)
.../plugins/plugin-chart-echarts/src/BoxPlot/index.ts	50.00% <ø> (ø)
...d/plugins/plugin-chart-echarts/src/Funnel/index.ts	50.00% <ø> (ø)
...nd/plugins/plugin-chart-echarts/src/Gauge/index.ts	50.00% <ø> (ø)
...ns/plugin-chart-echarts/src/Graph/EchartsGraph.tsx	0.00% <0.00%> (ø)
...nd/plugins/plugin-chart-echarts/src/Graph/index.ts	50.00% <ø> (ø)
... and 54 more

... and 298 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Always-prog]

@villebro I rebased PR, can I get review?

[villebro]

Tested to work as expected. However, I'd like to get sign-off from @kgabryje as I'm unsure if the previous useCallback is needed for perf reasons.

[kgabryje]

Tested, works great. Thanks for fixing that!