Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database test connection does not work after model has been saved #596

Closed
xrmx opened this issue Jun 10, 2016 · 2 comments · Fixed by #694
Closed

database test connection does not work after model has been saved #596

xrmx opened this issue Jun 10, 2016 · 2 comments · Fixed by #694
Labels
enhancement:request Enhancement request submitted by anyone from the community

Comments

@xrmx
Copy link
Contributor

xrmx commented Jun 10, 2016

Because the password is substituted with Xs. Could be an easy patch for someone willing to start contributing.
@xrmx xrmx mentioned this issue Jun 29, 2016
Closed
@xrmx xrmx mentioned this issue Jun 29, 2016
Merged
@xrmx xrmx mentioned this issue Jul 7, 2016
Closed
@jkeller-miovision
Copy link

I'm having this issue. I don't understand how this is usable for any db with a password. Is there a work-around? Has this always been broken? Thanks.

@xrmx
Copy link
Contributor Author

xrmx commented Jul 7, 2016

@jkeller-miovision don't panic, it's annoying but does not do any harm.

@xrmx xrmx added the enhancement:request Enhancement request submitted by anyone from the community label Aug 9, 2016
@dennisobrien dennisobrien mentioned this issue Sep 8, 2016
Closed
xrmx added a commit to xrmx/superset that referenced this issue Sep 13, 2016
@xrmx
Make sql test connection work with saved Database instance
c475b62 
Fix apache#596
dennisobrien added a commit to dennisobrien/caravel that referenced this issue Sep 15, 2016
@dennisobrien
Incorporate the tests from PR apache#694 which addresses apache#596
c795eb9
mistercrunch pushed a commit that referenced this issue Sep 17, 2016
@xrmx @mistercrunch
Make sql test connection work with saved Database instance (#694)
afa1f09 
Fix #596
dennisobrien pushed a commit to dennisobrien/caravel that referenced this issue Sep 19, 2016
@xrmx @dennisobrien
Make sql test connection work with saved Database instance (apache#694)
98da9a0 
Fix apache#596
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
@ktmud @zhaoyongjie
build: fix typing rebuild for single packages (apache#596)
f702fbd
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
@ktmud @zhaoyongjie
build: fix typing rebuild for single packages (apache#596)
ab97620
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
@ktmud @zhaoyongjie
build: fix typing rebuild for single packages (apache#596)
3e99be0
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
@ktmud @zhaoyongjie
build: fix typing rebuild for single packages (apache#596)
84672b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement:request Enhancement request submitted by anyone from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sql test connection work with saved Database instance xrmx/superset
2 participants
@xrmx @jkeller-miovision